[nodes-from-anchor] Allow PDA program to point to another instruction account

[PtSik]

I'm attempting to use @codama/nodes-from-anchor to convert an Anchor-generated IDL into the Codama format for client generation using @codama/renderers-js.

When running the conversion script, i encounter the following error:

/program/node_modules/@codama/nodes-from-anchor/src/v01/InstructionAccountNode.ts:137
                        throw new CodamaError(CODAMA_ERROR__ANCHOR__PROGRAM_ID_KIND_UNIMPLEMENTED, { kind });
                              ^


CodamaError: Program ID kind [account] is not implemented.
    at instructionAccountNodeFromAnchorV01 (/Users/kajman/coding/program/node_modules/@codama/nodes-from-anchor/src/v01/InstructionAccountNode.ts:137:31)
    at <anonymous> (/Users/kajman/coding/program/node_modules/@codama/nodes-from-anchor/src/v01/InstructionAccountNode.ts:43:16)
    at Array.flatMap (<anonymous>)
    at instructionAccountNodesFromAnchorV01 (/Users/kajman/coding/program/node_modules/@codama/nodes-from-anchor/src/v01/InstructionAccountNode.ts:40:16)
    at instructionNodeFromAnchorV01 (/Users/kajman/coding/program/node_modules/@codama/nodes-from-anchor/src/v01/InstructionNode.ts:31:19)
    at <anonymous> (/Users/kajman/coding/program/node_modules/@codama/nodes-from-anchor/src/v01/ProgramNode.ts:24:55)
    at Array.map (<anonymous>)
    at programNodeFromAnchorV01 (/Users/kajman/coding/program/node_modules/@codama/nodes-from-anchor/src/v01/ProgramNode.ts:24:36)
    at rootNodeFromAnchorV01 (/Users/kajman/coding/program/node_modules/@codama/nodes-from-anchor/src/v01/RootNode.ts:7:25)
    at rootNodeFromAnchorWithoutDefaultVisitor (/Users/kajman/coding/program/node_modules/@codama/nodes-from-anchor/src/index.ts:20:16) {
  context: { __code: 2100005, kind: 'account' }
}

Node.js v18.20.7

Example account definition structure from my IDL that causes the issue:

"program": {
    "kind": "account",
    "path": "token_metadata_program" 
}

However after manually editing pattern in IDL from "program": { "kind": "account", ... } to "program": { "kind": "const", ... }
creates the client successfully

anchor 0.31.1

[daog1]

@PtSik Bro, upload the IDL file, and I'll test it.

[Jeffrieh]

I'm running into the same issue, unable to upload the IDL right now but for me it seems to happen with IDL's generated when i use seeds::program to reference another program with anchor, like so:

 #[account(mut)]
 pub external_program_account: Account<'info, ExternalProgramAccount>,

 #[account(
        mut, 
        seeds = [external_program_account.key().as_ref()],
        bump,
        seeds::program = test_program.key(),
    )]
 pub test_token_account: Account<'info, TokenAccount>,
 pub test_program: Program<'info, ExternalProgram>,

this generates the following IDL account:

{
          "name": "test_token_account",
          "writable": true,
          "pda": {
            "seeds": [
              {
                "kind": "account",
                "path": "external_program_account"
              }
            ],
            "program": {
              "kind": "account",
              "path": "test_program"
            }
          }
        },

Indeed changing "account" to "const" inside of the "program" key like @PtSik mentioned seems to resolve the issue.

hope that helps in reproducing

[lorisleiva]

Thanks for raising this. I had a look into it to try and add support for the "account" and "arg" seed type for the program attribute of PDAs but ran into a more fundamental issue in the process. Whilst seeds themselves can reference other arguments and accounts within the instruction, the program ID currently has to be static on Codama — i.e. it has to be explicitly set on the IDL. This means, in its current state, Codama cannot use the value of another instruction account to set the program ID of another PDA account.

This is a limitation of the Codama IDL in its current state and we should definitely aim to fix this for v2.

[sonicfromnewyoke]

@PtSik @daog1 @Jeffrieh as a workaround you can do the next trick:

"program": {
-  "kind": "account",
+  "kind": "const",
-   "path": "token_metadata_program" 
+   "value": "<token_metadata_program public key>" 
}

[uidccnn]

I also encountered the same problem.

[zerokarafont]

same issue here, i try to generate from raydium launchlab idl

idl.json

[daog1]

I encountered an issue while testing Python renderers with the latest PumpFun and made a simple fix. Should I submit it?