fix: make serde field attrs dynamic and optional #13
+341
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b26e054 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
buffalojoec
force-pushed
the
optional-serde-callsites-rebaser
branch
from
0778d8d to
b26e054
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rust renderer supports a configuration object for determining what traits you'd like to be generated in the
#[derive(..)]attribute of each type. In this config, devs can specify what traits they want to be always implemented (ie.baseDefaults) or implemented behind a feature flag.However, there are two issues with the current implementation:
baseDefault, meaning it's not behind a feature flag, but the field attribute is still generated as#[cfg_attr(feature = "serde")].traitOptions, the field attributes are still generated.This PR adds a
getSerdeFieldAttributethat solves both issues. It evaluates all traits, including those behind a feature flag, and determines how to write the field attribute, if at all.