Skip to content

Commit 6b19626

Browse files
committed
perf: more descriptive error message in k8 test
1 parent 8984573 commit 6b19626

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

k8s/test.sh

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,14 +114,22 @@ downgrade_alembic_migrations() {
114114
if [ -n "$REFINERY_IMAGE_TAG_EXISTS" ]; then
115115
set +e
116116
kubectl exec -i deployment/test-${REFINERY_DEPLOYMENT_NAME} -c test-${REFINERY_DEPLOYMENT_NAME} -- alembic downgrade $REFINERY_ALEMBIC_VERSION
117-
echo "::warning::downgraded test-$REFINERY_DEPLOYMENT_NAME alembic version to $REFINERY_ALEMBIC_VERSION"
117+
if [ "$?" != "0" ]; then
118+
echo "::error::Alembic downgrade failed. Please update your code to support downgrading the current alembic version"
119+
else
120+
echo "::notice::downgraded test-$REFINERY_DEPLOYMENT_NAME alembic version to $REFINERY_ALEMBIC_VERSION"
121+
fi
118122
set -e
119123
kubectl delete --kustomize apps/${REFINERY_DEPLOYMENT_NAME}/test
120124
fi
121125
else
122126
set +e
123127
kubectl exec -i deployment/test-${KUBERNETES_DEPLOYMENT_NAME} -c test-${KUBERNETES_DEPLOYMENT_NAME} -- alembic downgrade $KUBERNETES_DEPLOYMENT_ALEMBIC_VERSION
124-
echo "::warning::downgraded test-$KUBERNETES_DEPLOYMENT_NAME alembic version to $KUBERNETES_DEPLOYMENT_ALEMBIC_VERSION"
128+
if [ "$?" != "0" ]; then
129+
echo "::error::Alembic downgrade failed. Please update your code to support downgrading the current alembic version"
130+
else
131+
echo "::notice::downgraded test-$KUBERNETES_DEPLOYMENT_NAME alembic version to $REFINERY_ALEMBIC_VERSION"
132+
fi
125133
set -e
126134
kubectl delete --kustomize apps/${KUBERNETES_DEPLOYMENT_NAME}/test
127135
fi

0 commit comments

Comments
 (0)