perf: use alembic rev for db migrations instead of num

Author: andhreljaKern

.github/workflows/k8s_db_rollback.yml

@@ -3,11 +3,11 @@ name: 'K8: Database Rollback'
 on:
   workflow_call:
     inputs:
-      num_migrations:
-        description: 'Number of migrations to rollback'
-        required: true
-        default: 0
-        type: number
+      alembic_downgrade_rev:
+        description: 'Rev of migration to rollback to'
+        required: false
+        default: 'base'
+        type: string
 
 # Special permissions required for OIDC authentication
 permissions:
@@ -56,45 +56,14 @@ jobs:
         cluster-name: ${{ env.KUBERNETES_CLUSTER_NAME }}
         admin: 'false'
         use-kubelogin: 'true'
-    
-    - name: Generate K8 Rollback Job
-      shell: bash
-      run: |
-        cp \
-          cicd-deployment-scripts/k8s/assets/db_rollback.tmpl \
-          apps/${{ github.event.repository.name }}/${{ github.ref_name }}/db_rollback.yaml
-        source cicd-deployment-scripts/k8s/db_rollback.sh \
-          -e ${{ github.ref_name }} \
-          -d ${{ github.event.repository.name }} \
-          -n ${{ env.KUBERNETES_NAMESPACE }} \
-          -r ${{ env.AZURE_CONTAINER_REGISTRY }} \
-          -t latest \
-          -m ${{ inputs.num_migrations }}
-        
-        generate_db_rollback_job
-
-    - name: Apply K8 Rollback Job
-      shell: bash
-      run: |
-        source cicd-deployment-scripts/k8s/db_rollback.sh \
-          -e ${{ github.ref_name }} \
-          -d ${{ github.event.repository.name }} \
-          -n ${{ env.KUBERNETES_NAMESPACE }} \
-          -r ${{ env.AZURE_CONTAINER_REGISTRY }} \
-          -t latest \
-          -m ${{ inputs.num_migrations }}
-        
-        apply_db_rollback_job
 
-    - name: Delete K8 Rollback Job
+    - name: Apply Alembic Rollback
       shell: bash
       run: |
-        source cicd-deployment-scripts/k8s/db_rollback.sh \
+        bash cicd-deployment-scripts/k8s/db_rollback.sh \
           -e ${{ github.ref_name }} \
           -d ${{ github.event.repository.name }} \
           -n ${{ env.KUBERNETES_NAMESPACE }} \
           -r ${{ env.AZURE_CONTAINER_REGISTRY }} \
           -t latest \
-          -m ${{ inputs.num_migrations }}
-        
-        delete_db_rollback_job
+          -a ${{ inputs.alembic_downgrade_rev }}

k8s/assets/db_rollback.tmpl

@@ -6,44 +6,23 @@ KUBERNETES_DEPLOYMENT_NAME=""
 KUBERNETES_NAMESPACE=""
 AZURE_CONTAINER_REGISTRY=""
 IMAGE_TAG=""
-num_migrations=""
+alembic_downgrade_rev=""
 
-while getopts e:d:r:t:n:m: flag
+while getopts e:d:r:t:n:a: flag
 do
     case "${flag}" in
         e) ENVIRONMENT_NAME=${OPTARG};;
         d) KUBERNETES_DEPLOYMENT_NAME=${OPTARG};;
         n) KUBERNETES_NAMESPACE=${OPTARG};;
         r) AZURE_CONTAINER_REGISTRY=${OPTARG};;
         t) IMAGE_TAG=${OPTARG};;
-        m) num_migrations=${OPTARG};;
+        a) alembic_downgrade_rev=${OPTARG};;
     esac
 done
 
 kubectl config set-context --current --namespace=$KUBERNETES_NAMESPACE
 echo "Context set to namespace: \"$KUBERNETES_NAMESPACE\""
 
-KUBERNETES_POD_IMAGE="${AZURE_CONTAINER_REGISTRY}/${KUBERNETES_DEPLOYMENT_NAME}:${IMAGE_TAG}"
-
-function generate_db_rollback_job {
-    echo "Generating DB Rollback job for ${KUBERNETES_DEPLOYMENT_NAME} in ${ENVIRONMENT_NAME}"
-    sed -i.bak 's|${KUBERNETES_DEPLOYMENT_NAME}|'${KUBERNETES_DEPLOYMENT_NAME}'|g' apps/${KUBERNETES_DEPLOYMENT_NAME}/${ENVIRONMENT_NAME}/db_rollback.tmpl
-    sed -i.bak 's|${KUBERNETES_POD_IMAGE}|'${KUBERNETES_POD_IMAGE}'|g' apps/${KUBERNETES_DEPLOYMENT_NAME}/${ENVIRONMENT_NAME}/db_rollback.tmpl
-    sed -i.bak 's|${num_migrations}|'${num_migrations}'|g' apps/${KUBERNETES_DEPLOYMENT_NAME}/${ENVIRONMENT_NAME}/db_rollback.tmpl
-
-    mv apps/${KUBERNETES_DEPLOYMENT_NAME}/${ENVIRONMENT_NAME}/db_rollback.tmpl apps/${KUBERNETES_DEPLOYMENT_NAME}/${ENVIRONMENT_NAME}/db_rollback.yml
-    echo "::notice::Generated DB Rollback job successfully"
-    cat apps/${KUBERNETES_DEPLOYMENT_NAME}/${ENVIRONMENT_NAME}/db_rollback.yml
-}
-
-function apply_db_rollback_job {
-    echo "Applying DB Rollback job for ${KUBERNETES_DEPLOYMENT_NAME} in ${ENVIRONMENT_NAME}"
-    kubectl apply --filename apps/${KUBERNETES_DEPLOYMENT_NAME}/${ENVIRONMENT_NAME}/db_rollback.yml
-    echo "::notice::Applied DB Rollback job successfully"
-}
-
-function delete_db_rollback_job {
-    echo "Deleting DB Rollback job for ${KUBERNETES_DEPLOYMENT_NAME} in ${ENVIRONMENT_NAME}"
-    kubectl delete --filename apps/${KUBERNETES_DEPLOYMENT_NAME}/${ENVIRONMENT_NAME}/db_rollback.yml
-    echo "::notice::Deleted DB Rollback job successfully"
-}
+echo "Rolling back to migration revision: $rev_rollback_migrations"
+kubectl exec -i deployment/${KUBERNETES_DEPLOYMENT_NAME} -c $KUBERNETES_DEPLOYMENT_NAME -- alembic downgrade ${rev_rollback_migrations}
+kubectl rollout status deployment/${KUBERNETES_DEPLOYMENT_NAME}