Skip to content

Fix builtin skill slash command registration#4633

Closed
muwenyan521 wants to merge 2 commits into
code-yeongyu:devfrom
muwenyan521:fix/init-deep-skill-command
Closed

Fix builtin skill slash command registration#4633
muwenyan521 wants to merge 2 commits into
code-yeongyu:devfrom
muwenyan521:fix/init-deep-skill-command

Conversation

@muwenyan521

@muwenyan521 muwenyan521 commented May 31, 2026

Copy link
Copy Markdown

Summary

Fixes #4714

  • Register builtin skills into OpenCode command config so migrated skill commands like /init-deep resolve again.
  • Keep builtin skill commands at the lowest precedence layer so existing builtin commands and user/project/plugin commands continue to override them.
  • Reuse existing builtin skill gates for disabled_skills, browser provider selection, and team_mode.enabled.

Tests

  • bun test src/plugin-handlers/command-config-handler.test.ts
  • bun test src/features/builtin-commands/init-deep-migration.test.ts src/hooks/auto-slash-command/init-deep-skill.test.ts src/features/builtin-skills/skills.test.ts src/features/builtin-skills/skills/team-mode.test.ts src/plugin/skill-context.test.ts
  • bun run typecheck

Summary by cubic

Registers builtin skills as commands so migrated slash commands like /init-deep work again, while keeping command precedence intact. Applies gating through existing config flags.

  • Bug Fixes
    • Add builtin skills to the command config at the lowest precedence so builtin commands and user/project/plugin commands override them.
    • Respect gates: disabled_skills, browser provider (playwright vs agent-browser), and team_mode.enabled.
    • Expand tests for inclusion, precedence (builtin command wins; project skill overrides builtin skill), and gating behavior.

Written for commit 1c15be6. Summary will update on new commits.

Review in cubic

@github-actions

github-actions Bot commented May 31, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA. Thank you! ✅
Posted by the CLA Assistant Lite bot.

@muwenyan521

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request May 31, 2026
dihak pushed a commit to dihak/oh-my-openagent that referenced this pull request May 31, 2026
@muwenyan521

Copy link
Copy Markdown
Author

This PR should fix #4714.

The issue reports that builtin shared-skills such as /init-deep, /review-work, /start-work, /refactor, /debugging, etc. are no longer visible as slash commands in OpenCode Desktop after the v4.5.x skill restructure.

The root cause matches this PR: builtin skills are created and available as skills, but they are not registered into OpenCode's command config, so Desktop/Web slash autocomplete does not see them.

This PR registers gated builtin skills as command definitions at the lowest precedence layer, so:

  • builtin commands still override same-name builtin skills
  • user/project/plugin commands and skills still override builtin skills
  • existing gates such as disabled_skills, browser provider selection, and team_mode.enabled are reused

@muwenyan521

Copy link
Copy Markdown
Author

@cubic-dev-ai rereview strict

@cubic-dev-ai

cubic-dev-ai Bot commented Jun 7, 2026

Copy link
Copy Markdown

@cubic-dev-ai rereview strict

@muwenyan521 I can't start this review because your workspace has reached its free monthly review limit. Reviews resume at the start of your next billing cycle. Paid plans include much higher monthly review limits. Upgrade now to resume reviews.

@muwenyan521

Copy link
Copy Markdown
Author

@code-yeongyu Could you please help review PR #4633 and approve the workflow? It fixes the missing built-in slash commands issue (#4714), all checks have passed. Thanks!

@code-yeongyu code-yeongyu force-pushed the fix/init-deep-skill-command branch from 4f9829f to e6becbe Compare June 10, 2026 07:24
…command

# Conflicts:
#	packages/omo-opencode/src/plugin-handlers/command-config-handler.ts
@muwenyan521

Copy link
Copy Markdown
Author

@code-yeongyu Hi! I have resolved the merge conflicts with the latest dev branch. All local checks passed. Could you please approve the workflow and take a review? Thanks inside!

@code-yeongyu

Copy link
Copy Markdown
Owner

[sisyphus-bot] Thanks @muwenyan521 for chasing #4714! Closing because dev shipped the identical fix independently (49c6b43 "register builtin skills as opencode slash commands" + fc471e5 for disabled_commands) — after your upstream merge, this PR's net delta vs dev is import reordering plus tests that largely duplicate dev's existing coverage in the same file. The ~3 genuinely novel gating tests (project-skill override of a builtin skill, browser-provider gating, team-mode gating at the command-config layer) would be welcome as a small test-only PR if you'd like the contribution credit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: v4.5.12 builtin shared-skills (init-deep, review-work, start-work, etc.) not visible as slash commands on OpenCode Desktop

2 participants