Fix builtin skill slash command registration#4633
Conversation
|
All contributors have signed the CLA. Thank you! ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
This PR should fix #4714. The issue reports that builtin shared-skills such as The root cause matches this PR: builtin skills are created and available as skills, but they are not registered into OpenCode's This PR registers gated builtin skills as command definitions at the lowest precedence layer, so:
|
|
@cubic-dev-ai rereview strict |
@muwenyan521 I can't start this review because your workspace has reached its free monthly review limit. Reviews resume at the start of your next billing cycle. Paid plans include much higher monthly review limits. Upgrade now to resume reviews. |
|
@code-yeongyu Could you please help review PR #4633 and approve the workflow? It fixes the missing built-in slash commands issue (#4714), all checks have passed. Thanks! |
4f9829f to
e6becbe
Compare
…command # Conflicts: # packages/omo-opencode/src/plugin-handlers/command-config-handler.ts
|
@code-yeongyu Hi! I have resolved the merge conflicts with the latest |
|
[sisyphus-bot] Thanks @muwenyan521 for chasing #4714! Closing because dev shipped the identical fix independently (49c6b43 "register builtin skills as opencode slash commands" + fc471e5 for disabled_commands) — after your upstream merge, this PR's net delta vs dev is import reordering plus tests that largely duplicate dev's existing coverage in the same file. The ~3 genuinely novel gating tests (project-skill override of a builtin skill, browser-provider gating, team-mode gating at the command-config layer) would be welcome as a small test-only PR if you'd like the contribution credit. |
Summary
Fixes #4714
/init-deepresolve again.disabled_skills, browser provider selection, andteam_mode.enabled.Tests
bun test src/plugin-handlers/command-config-handler.test.tsbun test src/features/builtin-commands/init-deep-migration.test.ts src/hooks/auto-slash-command/init-deep-skill.test.ts src/features/builtin-skills/skills.test.ts src/features/builtin-skills/skills/team-mode.test.ts src/plugin/skill-context.test.tsbun run typecheckSummary by cubic
Registers builtin skills as commands so migrated slash commands like
/init-deepwork again, while keeping command precedence intact. Applies gating through existing config flags.disabled_skills, browser provider (playwrightvsagent-browser), andteam_mode.enabled.Written for commit 1c15be6. Summary will update on new commits.