fix: remove fatal per-turn compaction cap - #728
Closed
realsigridjin wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks @realsigridjin (Sigrid) — the intent here was right: the per-turn soft cap made required compactions fatal mid-turn, and removing it in favor of the absolute session cap is exactly what landed. This PR could not pass the Changelog gate (runtime source changed without a
#731 is merged with full CI green, so closing this one in its favor. Credit for the diagnosis and direction stays with this PR. |
stevenahhh
pushed a commit
to stevenahhh/senpi
that referenced
this pull request
Aug 5, 2026
The per-turn soft cap (3 accepted + ineffective compactions) rejected required compactions mid-turn, fatally ending turns that legitimately needed more than three compactions. Admission is now bounded only by the absolute session cap (10) and the failure circuit breaker. The rejection cause keeps the historical per-turn-cap identifier for extension-API stability but reports the absolute session cap. Adds an RPC senpi-qa scenario driving 10 accepted compactions plus a non-fatal absolute-cap rejection against the real CLI. Supersedes code-yeongyu#728 by @realsigridjin; closes code-yeongyu#728.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm --prefix packages/coding-agent test -- test/compaction(52 files, 392 tests)npm run buildSummary by cubic
Removed the per-turn compaction cap so required compactions can continue within a turn. Compaction now only stops at the absolute session cap (10), preventing premature turn termination.
shouldRejectByCap; removed soft-cap checks.acceptedAbsolute.Written for commit bb08d0e. Summary will update on new commits.