fix(coding-agent): clean up Windows update and test workers - #741
Open
bokjk wants to merge 1 commit into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
SENPI_CODING_AGENT_DIRquarantines under a per-run Vitest root and remove that root during global teardownThis addresses the Windows
UV_HANDLE_CLOSINGteardown race and prevents normal repeated test runs from accumulatingsenpi-vitest-*directories.Verification
npm test -- test/omo-local-update-worker.test.ts test/omo-local-update-dispatch.test.ts test/setup-cleanup.test.ts— 3 files, 8 tests passed after rebasing onto current upstreammainnpm run check— passed after rebasenpm run build— passednode .agents/skills/senpi-qa/scripts/lib/common.mjs --self-check— 9/9 passednode .agents/skills/senpi-qa/scripts/cli-smoke.mjs --self-test— 8/8 passedsenpi-*entries after Vitest teardownFull-suite note
packages/coding-agentfull Vitest was also run after a workspace build. The changed tests passed, but the existing Windows suite remained non-green: 755 files passed / 68 failed / 9 skipped; 6,665 tests passed / 163 failed / 53 skipped, plus one unhandled error. Failures were in unrelated existing Windows-sensitive areas (for example POSIX permission assertions, install-method fixtures, external-editor shell quoting, and snapshot differences).Summary by cubic
Fixes a Windows teardown race in the OMO update worker and stops
vitestruns from leaving behindsenpi-vitest-*temp directories.defaultSpawnWorkerasync and kept the detached worker’s log handle open until the asynchronous close completes; the dispatcher now awaitsspawnWorker.SENPI_CODING_AGENT_DIRunder a per-runSENPI_VITEST_QUARANTINE_ROOTcreated viaglobalSetupand removed on global teardown; kept a process-exit cleanup fallback for standalone setup.Written for commit 08cd3b7. Summary will update on new commits.