Skip to content

Commit 4e98217

Browse files
jordienrclaudejoshenlim
authored
fix(studio): remove Supabase logo from Logs sidebar items (supabase#45787)
## Summary - Removes the `SupaIcon` component (inline Supabase SVG logo) from `LogsSidebarMenuV2.tsx` - Removes the `icon` prop from the Collections and Database operations sidebar items - Makes `icon` optional in `LogsSidebarItem` so the span is only rendered when an icon is provided Closes FE-3203 ## Test plan - [ ] Navigate to Logs & Analytics in Studio - [ ] Confirm Collections and Database operations sidebar items no longer show the Supabase logo - [ ] Confirm Saved Queries items still show the SQL editor icon (unaffected) 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Updated the logs sidebar component to make icon display optional. * Removed icons from sidebar items in the logs navigation to streamline the interface presentation. [![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/supabase/supabase/pull/45787) <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Joshen Lim <joshenlimek@gmail.com>
1 parent 04b09b2 commit 4e98217

2 files changed

Lines changed: 4 additions & 22 deletions

File tree

apps/studio/components/interfaces/Settings/Logs/SidebarV2/SidebarItem.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
import { MoreHorizontal } from 'lucide-react'
22
import Link from 'next/link'
3+
import { type MouseEventHandler } from 'react'
34
import { Button, cn, DropdownMenu, DropdownMenuContent, DropdownMenuTrigger } from 'ui'
45

56
type Props = {
67
label: string
7-
icon: React.ReactNode
8+
icon?: React.ReactNode
89
dropdownItems?: React.ReactNode
910
href: string
1011
isActive: boolean
11-
onClick?: (e: any) => void
12+
onClick?: MouseEventHandler<HTMLAnchorElement>
1213
}
1314
export function LogsSidebarItem({ label, icon, dropdownItems, href, isActive, onClick }: Props) {
1415
return (
@@ -25,7 +26,7 @@ export function LogsSidebarItem({ label, icon, dropdownItems, href, isActive, on
2526
href={href}
2627
className={'h-7 flex-1 text-sm px-4 flex items-center gap-2 truncate'}
2728
>
28-
<span>{icon}</span>
29+
{icon && <span>{icon}</span>}
2930
<span className="truncate">{label}</span>
3031
</Link>
3132
{dropdownItems && (

apps/studio/components/layouts/LogsLayout/LogsSidebarMenuV2.tsx

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -35,23 +35,6 @@ import { useReplicationSourcesQuery } from '@/data/replication/sources-query'
3535
import { useCheckEntitlements } from '@/hooks/misc/useCheckEntitlements'
3636
import { useIsFeatureEnabled } from '@/hooks/misc/useIsFeatureEnabled'
3737

38-
const SupaIcon = ({ className }: { className?: string }) => {
39-
return (
40-
<svg
41-
stroke="currentColor"
42-
fill="currentColor"
43-
strokeWidth="0"
44-
viewBox="0 0 24 24"
45-
height="15px"
46-
width="15px"
47-
className={className}
48-
xmlns="http://www.w3.org/2000/svg"
49-
>
50-
<path d="M10.9997 2.59833V13.9694H3.90013C3.23055 13.9694 2.83063 13.1846 3.25654 12.6326L10.9997 2.59833ZM12.9997 8.03061V2.33296C12.9997 0.521514 10.7034 -0.291434 9.58194 1.16185L1.67316 11.4108C0.246185 13.26 1.54768 15.9694 3.90013 15.9694H10.9997V21.6671C10.9997 23.4785 13.296 24.2915 14.4175 22.8382L22.3262 12.5892C23.7532 10.74 22.4517 8.03061 20.0993 8.03061H12.9997ZM12.9997 10.0306H20.0993C20.7688 10.0306 21.1688 10.8155 20.7429 11.3674L12.9997 21.4017V10.0306Z"></path>
51-
</svg>
52-
)
53-
}
54-
5538
export function SidebarCollapsible({
5639
children,
5740
title,
@@ -323,7 +306,6 @@ export function LogsSidebarMenuV2() {
323306
key={collection?.key ?? ''}
324307
isActive={isItemActive}
325308
href={collection?.url ?? ''}
326-
icon={<SupaIcon className="text-foreground-light" />}
327309
label={collection?.name ?? ''}
328310
/>
329311
)
@@ -338,7 +320,6 @@ export function LogsSidebarMenuV2() {
338320
key={collection.key}
339321
isActive={isActive(collection.url)}
340322
href={collection.url}
341-
icon={<SupaIcon className="text-foreground-light" />}
342323
label={collection.name}
343324
/>
344325
))}

0 commit comments

Comments
 (0)