fix: party creation page crash from eager JS reload

make-empty-party had :on-success (.reload js/window.location true)
which evaluated eagerly during map construction, reloading the page
before the POST even completed. Replaced with a proper dispatch
vector to a new make-empty-party-success handler that appends the
new party to app-db reactively, matching the existing make-party
pattern.

Author: codeGlaze

src/cljs/orcpub/dnd/e5/events.cljs

@@ -756,6 +756,15 @@
                             ::party5e/character-ids character-ids}
            :on-success [::party5e/make-party-success]}}))
 
+(reg-event-fx
+ ::party5e/make-empty-party-success
+ (fn [{:keys [db]} [_ response]]
+   (let [new-party (:body response)
+         parties (conj (vec (::char5e/parties db)) new-party)]
+     {:db (assoc db
+                 ::char5e/parties parties
+                 ::char5e/parties-map (common/map-by-id parties))})))
+
 (reg-event-fx
   ::party5e/make-empty-party
   (fn [{:keys [db]} [_]]
@@ -764,8 +773,7 @@
             :headers (authorization-headers db)
             :url (url-for-route routes/dnd-e5-char-parties-route)
             :transit-params {::party5e/name "A New Party"}
-            :on-success (.reload js/window.location true)
-            }}))
+            :on-success [::party5e/make-empty-party-success]}}))
 
 (reg-event-fx
  ::party5e/rename-party