fix: add handler for ActiveRecord::RecordInvalid exceptions

Author: mroderick

app/controllers/concerns/admin/sponsor_concerns.rb

@@ -27,14 +27,14 @@ def destroy_sponsor
     def host
       set_sponsor
       @workshop_sponsor = WorkshopSponsor.find_or_create_by(workshop: @workshop, sponsor: @sponsor)
-      @workshop_sponsor.update_attribute(:host, true)
+      @workshop_sponsor.set_as_host!
       flash[:notice] = 'Host set successfully'
 
       redirect_back fallback_location: root_path
     end
 
     def destroy_host
-      @workshop.workshop_sponsors.find_by(host: true).update_attribute(:host, false)
+      @workshop.workshop_sponsors.find_by(host: true)&.remove_as_host!
 
       redirect_back fallback_location: root_path
     end

app/controllers/concerns/invitation_controller_concerns.rb

@@ -35,26 +35,25 @@ def accept
     def reject
       @workshop = WorkshopPresenter.decorate(@invitation.workshop)
       if @invitation.workshop.date_and_time - 3.5.hours >= Time.zone.now
-
         if @invitation.attending.eql? false
           redirect_back(fallback_location: invitation_path(@invitation),
                         notice: t('messages.not_attending_already'))
         else
-          @invitation.update_attribute(:attending, false)
-
-          next_spot = WaitingList.next_spot(@invitation.workshop, @invitation.role)
-
-          if next_spot.present?
-            invitation = next_spot.invitation
-            next_spot.destroy
-            invitation.update(attending: true, rsvp_time: Time.zone.now, automated_rsvp: true)
-            @workshop.send_attending_email(invitation, true)
+          begin
+            WorkshopInvitation.transaction do
+              @invitation.decline!
+              promote_from_waitlist(@invitation.workshop, @invitation.role)
+            end
+            redirect_back(
+              fallback_location: invitation_path(@invitation),
+              notice: t('messages.rejected_invitation', name: @invitation.member.name)
+            )
+          rescue ActiveRecord::RecordInvalid
+            redirect_back(
+              fallback_location: invitation_path(@invitation),
+              alert: 'Unable to process cancellation. Please try again.'
+            )
           end
-
-          redirect_back(
-            fallback_location: invitation_path(@invitation),
-            notice: t('messages.rejected_invitation', name: @invitation.member.name)
-          )
         end
       else
         redirect_back(
@@ -66,6 +65,16 @@ def reject
 
     private
 
+    def promote_from_waitlist(workshop, role)
+      next_spot = WaitingList.next_spot(workshop, role)
+      return unless next_spot
+
+      invitation = next_spot.invitation
+      next_spot.destroy!
+      invitation.accept!(rsvp_time: Time.zone.now, automated_rsvp: true)
+      WorkshopPresenter.decorate(workshop).send_attending_email(invitation, true)
+    end
+
     def attending_or_waitlisted?(workshop, user)
       workshop.attendee?(user) || workshop.waitlisted?(user)
     end

app/controllers/invitations_controller.rb

@@ -27,12 +27,12 @@ def attend
     return redirect_back fallback_location: root_path, notice: t('messages.already_rsvped') if @invitation.attending?
 
     if @invitation.student_spaces? || @invitation.coach_spaces?
-      @invitation.update_attribute(:attending, true)
+      @invitation.accept!
 
       notice = t('messages.invitations.spot_confirmed', event: @invitation.event.name)
 
       unless event.confirmation_required || event.surveys_required
-        @invitation.update_attribute(:verified, true)
+        @invitation.verify!
         EventInvitationMailer.attending(@invitation.event, @invitation.member, @invitation).deliver_now
       end
       notice = t('messages.invitations.spot_not_confirmed') if event.surveys_required
@@ -54,7 +54,7 @@ def reject
       )
     end
 
-    @invitation.update_attribute(:attending, false)
+    @invitation.decline!
     redirect_back(
       fallback_location: root_path,
       notice: t('messages.rejected_invitation', name: @invitation.member.name)
@@ -79,7 +79,7 @@ def rsvp_meeting
   def cancel_meeting
     @invitation = MeetingInvitation.find_by(token: params[:token])
 
-    @invitation.update_attribute(:attending, false)
+    @invitation.decline!
 
     redirect_back fallback_location: root_path, notice: t('messages.invitations.meeting.cancel')
   end

spec/controllers/admin/invitations_controller_spec.rb

@@ -3,43 +3,43 @@
   let(:workshop) { invitation.workshop }
   let(:admin) { Fabricate(:chapter_organiser) }
 
-  describe "PUT #update" do
+  describe 'PUT #update' do
     before do
       admin.add_role(:organiser, workshop.chapter)
 
       login admin
-      request.env["HTTP_REFERER"] = "/admin/member/3"
+      request.env['HTTP_REFERER'] = '/admin/member/3'
 
       expect(invitation.attending).to be_nil
     end
 
-    it "Successfuly updates an invitation" do
-      put :update, params: { id: invitation.token, workshop_id: workshop.id, attending: "true" }
-      
+    it 'Successfuly updates an invitation' do
+      put :update, params: { id: invitation.token, workshop_id: workshop.id, attending: 'true' }
+
       expect(invitation.reload.attending).to be true
-      expect(flash[:notice]).to match("You have added")
+      expect(flash[:notice]).to match('You have added')
     end
 
     # While similar to the previous test, this specifically tests that organisers
     # have the ability to manually add a student to the workshop that has not
     # selected a tutorial. This is helpful for when a student shows up for a
     # workshop they have not have a spot — this happens from time to time.
-    it "Successfuly adds a user as attenting, even without a tutorial" do
-      invitation.update_attribute(:tutorial, nil)
+    it 'Successfuly adds a user as attenting, even without a tutorial' do
+      invitation.update_column(:tutorial, nil)
       expect(invitation.automated_rsvp).to be_nil
 
-      put :update, params: { id: invitation.token, workshop_id: workshop.id, attending: "true" }
+      put :update, params: { id: invitation.token, workshop_id: workshop.id, attending: 'true' }
       invitation.reload
 
       expect(invitation.attending).to be true
       expect(invitation.automated_rsvp).to be true
-      expect(flash[:notice]).to match("You have added")
+      expect(flash[:notice]).to match('You have added')
     end
 
-    it "Records the organiser ID that overrides an invitations" do
-      put :update, params: { id: invitation.token, workshop_id: workshop.id, attending: "true" }
+    it 'Records the organiser ID that overrides an invitations' do
+      put :update, params: { id: invitation.token, workshop_id: workshop.id, attending: 'true' }
       invitation.reload
-      
+
       expect(invitation.last_overridden_by_id).to be admin.id
     end
   end

spec/features/accepting_invitation_spec.rb

@@ -1,18 +1,18 @@
 RSpec.feature 'Accepting a workshop invitation', type: :feature do
-  context '#workshop' do
+  describe '#workshop' do
     let(:member) { Fabricate(:member) }
     let(:invitation) { Fabricate(:workshop_invitation, member: member, tutorial: tutorial.title) }
     let(:invitation_route) { invitation_path(invitation) }
     let(:accept_invitation_route) { accept_invitation_path(invitation) }
     let(:reject_invitation_route) { reject_invitation_path(invitation) }
-    let(:set_no_available_slots) { invitation.workshop.host.update_attribute(:seats, 0) }
+    let(:set_no_available_slots) { invitation.workshop.host.update_column(:seats, 0) }
     let!(:tutorial) { Fabricate(:tutorial) }
 
     it_behaves_like 'invitation route'
 
     context 'amend invitation details' do
       context 'a student' do
-        scenario 'cannot accept an invitation  without a tutorial' do
+        scenario 'cannot accept an invitation without a tutorial' do
           invitation.update(attending: nil, tutorial: nil)
           visit invitation_route
 
@@ -22,7 +22,7 @@
         end
 
         scenario 'with an accepted invitation can edit the tutorial' do
-          invitation.update_attribute(:attending, true)
+          invitation.accept!
           visit invitation_route
 
           select tutorial.title, from: :workshop_invitation_tutorial
@@ -66,7 +66,7 @@
           click_on 'Update note'
 
           expect(page).to have_field('workshop_invitation_note', with: note)
-          expect(page).to have_content("Invitation details successfully updated.")
+          expect(page).to have_content('Invitation details successfully updated.')
         end
       end
     end

spec/features/coach_accepting_invitation_spec.rb

@@ -1,14 +1,14 @@
 RSpec.feature 'a Coach can', type: :feature do
-  context '#workshop' do
+  describe '#workshop' do
     let(:member) { Fabricate(:member) }
     let(:invitation) { Fabricate(:coach_workshop_invitation, member: member) }
     let(:invitation_route) { invitation_path(invitation) }
     let(:reject_invitation_route) { reject_invitation_path(invitation) }
     let(:accept_invitation_route) { accept_invitation_path(invitation) }
 
-    let(:set_no_available_slots) { invitation.workshop.host.update_attribute(:seats, 0) }
+    let(:set_no_available_slots) { invitation.workshop.host.update_column(:seats, 0) }
 
-    before(:each) do
+    before do
       login(member)
     end
 

spec/models/workshop_spec.rb

@@ -1,12 +1,13 @@
 RSpec.describe Workshop do
   subject(:workshop) { Fabricate(:workshop) }
-  include_examples "Invitable", :workshop_invitation, :workshop
+
+  include_examples 'Invitable', :workshop_invitation, :workshop
   include_examples DateTimeConcerns, :workshop
 
   context 'validates' do
     it { is_expected.to validate_presence_of(:chapter_id) }
 
-    context "#date_and_time" do
+    describe '#date_and_time' do
       it 'does not validate if chapter_id blank' do
         workshop.chapter_id = nil
         workshop.date_and_time = nil
@@ -22,7 +23,7 @@
       end
     end
 
-    context '#end_at' do
+    describe '#end_at' do
       it 'does not validate if chapter_id blank' do
         workshop.chapter_id = nil
         workshop.ends_at = nil
@@ -40,6 +41,7 @@
 
     context 'if virtual' do
       before { allow(subject).to receive(:virtual?).and_return(true) }
+
       it { is_expected.to validate_presence_of(:slack_channel) }
       it { is_expected.to validate_presence_of(:slack_channel_link) }
       it { is_expected.to validate_numericality_of(:student_spaces).is_greater_than(0) }
@@ -63,7 +65,8 @@
       end
 
       it 'retrieves the local time from the saved UTC value' do
-        workshop.update_attribute(:date_and_time, utc_time)
+        workshop.assign_attributes(date_and_time: utc_time)
+        workshop.save!(validate: false)
 
         expect(workshop.date_and_time).to eq(pacific_time)
         expect(workshop.date_and_time.zone).to eq('PDT')
@@ -81,15 +84,16 @@
       end
 
       it 'retrieves the local time from the saved UTC value' do
-        workshop.update_attribute(:rsvp_opens_at, utc_time)
+        workshop.assign_attributes(rsvp_opens_at: utc_time)
+        workshop.save!(validate: false)
 
         expect(workshop.rsvp_opens_at).to eq(pacific_time)
         expect(workshop.rsvp_opens_at.zone).to eq('PDT')
       end
     end
   end
 
-  context '#rsvp_available?' do
+  describe '#rsvp_available?' do
     context 'rsvp is available' do
       it 'when the event is in the future' do
         workshop.date_and_time = 1.day.from_now
@@ -119,7 +123,7 @@
     end
   end
 
-  context '#to_s' do
+  describe '#to_s' do
     it 'when physical workshop' do
       expect(workshop.to_s).to eq('Workshop')
     end
@@ -130,7 +134,7 @@
     end
   end
 
-  context '#scopes' do
+  describe '#scopes' do
     describe '#host' do
       it 'includes workshops with sponsored hosts' do
         workshop_sponsor = Fabricate(:workshop_sponsor, host: true)
@@ -189,7 +193,7 @@
     end
   end
 
-  context '#invitable_yet?' do
+  describe '#invitable_yet?' do
     it 'is invitable if invitable set to true, no RSVP open time/date set' do
       workshop = Fabricate.build(:workshop, invitable: true)
       expect(workshop.invitable_yet?).to be true

spec/presenters/invitation_presenter_spec.rb

@@ -6,9 +6,9 @@
     expect(invitation_presenter.member).to eq(invitation.member)
   end
 
-  context '#attendance_status' do
+  describe '#attendance_status' do
     it 'returns Attending when attending' do
-      invitation.update_attribute(:attending, true)
+      invitation.accept!
 
       expect(invitation_presenter.attendance_status).to eq('Attending')
     end