Merge pull request #88 from codeclimate/abh-clean-specs

Minor refactor

Author: Ashley Baldwin-Hunter

spec/cc/engine/analyzers/javascript/main_spec.rb

@@ -1,9 +1,8 @@
+require 'spec_helper'
 require 'cc/engine/analyzers/javascript/main'
 require 'cc/engine/analyzers/reporter'
 require 'cc/engine/analyzers/engine_config'
 require 'cc/engine/analyzers/file_list'
-require 'flay'
-require 'tmpdir'
 
 RSpec.describe CC::Engine::Analyzers::Javascript::Main, in_tmpdir: true do
   include AnalyzerSpecHelpers
@@ -93,8 +92,8 @@
           <a className='button button-primary full' href='#' onClick={this.onSubmit.bind(this)}>Login</a>
     EOJSX
 
-    result = run_engine(engine_conf).strip
-    issues = result.split("\0")
+    issues = run_engine(engine_conf).strip.split("\0")
+
     expect(issues.length).to eq 1
   end
 

spec/cc/engine/analyzers/php/main_spec.rb

@@ -1,9 +1,8 @@
+require 'spec_helper'
 require 'cc/engine/analyzers/php/main'
 require 'cc/engine/analyzers/reporter'
 require 'cc/engine/analyzers/engine_config'
 require 'cc/engine/analyzers/file_list'
-require 'flay'
-require 'tmpdir'
 
 RSpec.describe CC::Engine::Analyzers::Php::Main, in_tmpdir: true do
   include AnalyzerSpecHelpers
@@ -93,11 +92,6 @@
     end
   end
 
-  def printed_issue
-    issue = {"type":"issue","check_name":"Identical code","description":"Similar code found in 1 other location","categories":["Duplication"],"location":{"path":"foo.php","lines":{"begin":2,"end":6}},"remediation_points":176000,"other_locations":[{"path":"foo.php","lines":{"begin":10,"end":14}}],"content":{"body": read_up}}
-    issue.to_json + "\0\n"
-  end
-
   def engine_conf
     CC::Engine::Analyzers::EngineConfig.new({
       'config' => {

spec/cc/engine/analyzers/python/main_spec.rb

@@ -1,9 +1,7 @@
-require "spec_helper"
-require "cc/engine/analyzers/python/main"
+require 'spec_helper'
+require 'cc/engine/analyzers/python/main'
 require 'cc/engine/analyzers/engine_config'
 require 'cc/engine/analyzers/file_list'
-require "flay"
-require "tmpdir"
 
 RSpec.describe CC::Engine::Analyzers::Python::Main, in_tmpdir: true do
   include AnalyzerSpecHelpers

spec/cc/engine/analyzers/ruby/main_spec.rb

@@ -1,8 +1,7 @@
+require 'spec_helper'
 require 'cc/engine/analyzers/ruby/main'
 require 'cc/engine/analyzers/engine_config'
 require 'cc/engine/analyzers/file_list'
-require 'flay'
-require 'tmpdir'
 
 module CC::Engine::Analyzers
   RSpec.describe Ruby::Main, in_tmpdir: true do

spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require 'bundler/setup'
+require 'flay'
 require 'tmpdir'
 
 Dir[File.dirname(__FILE__) + "/support/**/*.rb"].each {|f| require f }