Skip to content

Fail_ci_if_error not actually passing when false #1703

Open
@yarikoptic

Description

@yarikoptic

Further details and analysis: dandi/dandi-schema#268 (comment)

but here is what we see

Image

see e.g. in https://github.com/dandi/dandi-schema/actions/runs/12004231865/job/33458888905

and oddly the whole workflow marks that matrix run failed although our config has

https://github.com/dandi/dandi-schema/blob/HEAD/.github/workflows/test.yml#L55

        fail_ci_if_error: false

so there might be two issues ;-)

Metadata

Metadata

Labels

Area: Report UploadIssues with pre-ingest report uploadingEng Area: Codecov GitHub ActionLowLow Priority Issues (to be fixed or re-evaluated in 12 monthsbugSomething isn't working

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions