Skip to content

Commit 935eeb1

Browse files
committed
try to fix delete session test
1 parent 1f4b0d6 commit 935eeb1

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

graphql_api/tests/mutation/test_delete_session.py

+6-11
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,18 @@
2020
class DeleteSessionTestCase(GraphQLTestHelper, TransactionTestCase):
2121
def setUp(self):
2222
self.owner = OwnerFactory(username="codecov-user")
23+
user = self.user = UserFactory()
24+
self.owner.user = user
25+
self.owner.save()
26+
27+
# clear pre-existing login sessions, as some testcase seems to leak these
28+
DjangoSession.objects.all().delete()
2329

2430
def test_when_unauthenticated(self):
2531
data = self.gql_request(query, variables={"input": {"sessionid": 1}})
2632
assert data["deleteSession"]["error"]["__typename"] == "UnauthenticatedError"
2733

2834
def test_when_authenticated(self):
29-
user = UserFactory()
30-
self.owner.user = user
31-
self.owner.save()
32-
33-
django_session_id = DjangoSession.objects.all()
34-
assert len(django_session_id) == 0
35-
3635
login_query = "{ me { user { username }} }"
3736
self.gql_request(login_query, owner=self.owner)
3837

@@ -59,10 +58,6 @@ def test_when_authenticated(self):
5958
assert len(Session.objects.filter(sessionid=sessionid)) == 0
6059

6160
def test_when_authenticated_session_not_valid(self):
62-
user = UserFactory()
63-
self.owner.user = user
64-
self.owner.save()
65-
6661
login_query = "{ me { user { username }} }"
6762
self.gql_request(login_query, owner=self.owner)
6863

0 commit comments

Comments
 (0)