Interpolation of files flag

[jaydorsey]

I have a config file that has a setup like this:

      - codecov/upload:
          files: coverage-results/backend-${CIRCLE_NODE_INDEX}.xml
          disable_search: true

It appears that ${CIRCLE_NODE_INDEX} isn't getting interpolated. I expected it to, so I'm not sure if that's a bug, a miss on my part (not seeing the right documentation), or an undocumented behavior.

The documentation that is there says files is "Comma-separated list of explicit files to upload. These will be added to the coverage files found for upload. If you wish to only upload the specified files, please consider using disable-search to disable uploading other files."

When I upgraded our orb recently and we switched to using files, I also set disable_search because we have a pretty explicit file name we wanted to include (it just relies on that ENV, which is set)

The actual behavior seems to be that the files is not interpolated/expanded (but some glob behaviors might work per other comments)

I don't know enough about the orb behavior themselves to know if this can be improved to allow for interpolation, but if not, would you be open to a pull request to improve the documentation on the files behavior so it's clear whether interpolation or globbing are supported by that string?

Note: I worked around this by removing disable_search

[thomasrockhu-codecov]

@jaydorsey definitely open to a PR. AFAIK, the files argument is not going to interpolate ${CIRCLE_NODE_INDEX}. I can dig into what we might have to do to support that behavior.