Skip to content

Commit 3069c0f

Browse files
Couple small fixes
1 parent 6e309e5 commit 3069c0f

File tree

5 files changed

+5
-8
lines changed

5 files changed

+5
-8
lines changed

src/layouts/Header/components/UserDropdown/UserDropdown.tsx

-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ import { Dropdown } from 'ui/Dropdown/Dropdown'
1212

1313
interface URLParams {
1414
provider: Provider
15-
owner: string
16-
repo?: string
1715
}
1816

1917
type DropdownItem = {

src/pages/OwnerPage/HeaderBanners/GithubConfigBanner/GithubConfigBanner.jsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import BannerContent from 'ui/Banner/BannerContent'
88
import BannerHeading from 'ui/Banner/BannerHeading'
99

1010
const GithubConfigBanner = () => {
11-
const { provider, owner } = useParams()
11+
const { provider } = useParams()
1212
const isGh = providerToName(provider) === 'GitHub'
1313

1414
if (!isGh) return null
@@ -23,7 +23,7 @@ const GithubConfigBanner = () => {
2323
data-testid="codecovGithubApp-link"
2424
to={{ pageName: 'codecovGithubAppSelectTarget' }}
2525
onClick={() =>
26-
eventTracker(provider, owner).track({
26+
eventTracker().track({
2727
type: 'Button Clicked',
2828
properties: {
2929
buttonType: 'Install GitHub App',

src/services/events/amplitude/amplitude.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@ export class AmplitudeEventTracker implements EventTracker {
4646
...event.properties,
4747
...this.context,
4848
},
49-
// This attaches the event to the owner's user group as well
49+
// This attaches the event to the owner's user group (org) as well
5050
groups: this.context.owner?.id
5151
? {
52-
owner: this.context.owner.id,
52+
org: this.context.owner.id,
5353
}
5454
: undefined,
5555
})

src/services/events/types.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export type Event =
3030
| {
3131
type: 'Page Viewed'
3232
properties: {
33-
pageName: 'OwnerPage'
33+
pageName: 'Owner Page'
3434
}
3535
}
3636

src/services/user/useUser.ts

-1
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@ fragment CurrentUserFragment on Me {
127127

128128
interface URLParams {
129129
provider: Provider
130-
owner: string
131130
}
132131

133132
interface UseUserArgs {

0 commit comments

Comments
 (0)