Skip to content

Commit 3e1b759

Browse files
fix: Alternative without useEffect for prev generated token
1 parent 9cf61eb commit 3e1b759

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

src/pages/RepoPage/CoverageOnboarding/GitHubActions/GitHubActions.tsx

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { useEffect, useRef, useState } from 'react'
1+
import { useRef, useState } from 'react'
22
import { useParams } from 'react-router-dom'
33

44
import { useOrgUploadToken } from 'services/orgUploadToken'
@@ -53,13 +53,11 @@ function GitHubActions() {
5353
(isUsingGlobalToken && !!orgUploadToken) ||
5454
(!isUsingGlobalToken && !!repoUploadToken)
5555

56-
useEffect(() => {
57-
// Only set this on initial render
58-
if (previouslyGeneratedOrgToken.current === undefined) {
59-
previouslyGeneratedOrgToken.current = orgUploadToken
60-
}
61-
// eslint-disable-next-line react-hooks/exhaustive-deps
62-
}, [])
56+
// If orgUploadToken does not exist on initial render, set it to null and we
57+
// do not touch it again on rerenders
58+
if (previouslyGeneratedOrgToken.current === undefined) {
59+
previouslyGeneratedOrgToken.current = orgUploadToken ?? null
60+
}
6361

6462
const [framework, setFramework] = useState<Framework>('Jest')
6563

0 commit comments

Comments
 (0)