Skip to content

Commit e3294d3

Browse files
authored
feat: Update useBundleAssets to fetch routes field (#3527)
1 parent 354e880 commit e3294d3

File tree

5 files changed

+23
-47
lines changed

5 files changed

+23
-47
lines changed

src/pages/RepoPage/BundlesTab/BundleContent/AssetsTable/AssetsTable.test.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import { AssetsTable, ChangeOverTime } from './AssetsTable'
1616
const mockAssets = (hasNextPage = true) => {
1717
const asset1 = {
1818
name: 'asset-1',
19+
routes: ['/'],
1920
extension: 'js',
2021
bundleData: {
2122
loadTime: { threeG: 2000, highSpeed: 2000 },
@@ -32,6 +33,7 @@ const mockAssets = (hasNextPage = true) => {
3233

3334
const asset2 = {
3435
name: 'asset-2',
36+
routes: ['/about'],
3537
extension: 'js',
3638
bundleData: {
3739
loadTime: { threeG: 2000, highSpeed: 2000 },
@@ -48,6 +50,7 @@ const mockAssets = (hasNextPage = true) => {
4850

4951
const asset3 = {
5052
name: 'asset-3',
53+
routes: ['/login'],
5154
extension: 'js',
5255
bundleData: {
5356
loadTime: { threeG: 2000, highSpeed: 2000 },

src/pages/RepoPage/BundlesTab/BundleContent/AssetsTable/useBundleAssetsTable.test.tsx

Lines changed: 14 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -50,34 +50,22 @@ const mockedBundleAssets = {
5050
{
5151
node: {
5252
name: 'asset-1',
53+
routes: ['/'],
5354
extension: 'js',
5455
bundleData: {
55-
loadTime: {
56-
threeG: 1,
57-
highSpeed: 2,
58-
},
59-
size: {
60-
uncompress: 3,
61-
gzip: 4,
62-
},
56+
loadTime: { threeG: 1, highSpeed: 2 },
57+
size: { uncompress: 3, gzip: 4 },
6358
},
6459
measurements: {
65-
change: {
66-
size: {
67-
uncompress: 5,
68-
},
69-
},
60+
change: { size: { uncompress: 5 } },
7061
measurements: [
7162
{ timestamp: '2022-10-10T11:59:59', avg: 6 },
7263
],
7364
},
7465
},
7566
},
7667
],
77-
pageInfo: {
78-
hasNextPage: false,
79-
endCursor: null,
80-
},
68+
pageInfo: { hasNextPage: false, endCursor: null },
8169
},
8270
},
8371
},
@@ -165,42 +153,21 @@ describe('useBundleAssetsTable', () => {
165153
{
166154
assets: [
167155
{
156+
name: 'asset-1',
157+
routes: ['/'],
158+
extension: 'js',
168159
bundleData: {
169-
loadTime: {
170-
highSpeed: 2,
171-
threeG: 1,
172-
},
173-
size: {
174-
gzip: 4,
175-
uncompress: 3,
176-
},
160+
loadTime: { highSpeed: 2, threeG: 1 },
161+
size: { gzip: 4, uncompress: 3 },
177162
},
178-
extension: 'js',
179163
measurements: {
180-
change: {
181-
size: {
182-
uncompress: 5,
183-
},
184-
},
185-
measurements: [
186-
{
187-
avg: 6,
188-
timestamp: '2022-10-10T11:59:59',
189-
},
190-
],
164+
change: { size: { uncompress: 5 } },
165+
measurements: [{ avg: 6, timestamp: '2022-10-10T11:59:59' }],
191166
},
192-
name: 'asset-1',
193167
},
194168
],
195-
bundleData: {
196-
size: {
197-
uncompress: 12,
198-
},
199-
},
200-
pageInfo: {
201-
endCursor: null,
202-
hasNextPage: false,
203-
},
169+
bundleData: { size: { uncompress: 12 } },
170+
pageInfo: { endCursor: null, hasNextPage: false },
204171
},
205172
],
206173
}

src/pages/RepoPage/BundlesTab/BundleContent/BundleContent.test.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ const mockAssets = {
109109
{
110110
node: {
111111
name: 'asset-1',
112+
routes: ['/'],
112113
extension: 'js',
113114
bundleData: {
114115
loadTime: {

src/services/bundleAnalysis/useBundleAssets.test.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import { useBundleAssets } from './useBundleAssets'
1212

1313
const node1 = {
1414
name: 'asset-1',
15+
routes: ['/'],
1516
extension: 'js',
1617
bundleData: {
1718
loadTime: { threeG: 1, highSpeed: 2 },
@@ -25,6 +26,7 @@ const node1 = {
2526

2627
const node2 = {
2728
name: 'asset-2',
29+
routes: ['/login'],
2830
extension: 'js',
2931
bundleData: {
3032
loadTime: { threeG: 1, highSpeed: 2 },
@@ -38,6 +40,7 @@ const node2 = {
3840

3941
const node3 = {
4042
name: 'asset-3',
43+
routes: ['/about'],
4144
extension: 'js',
4245
bundleData: {
4346
loadTime: { threeG: 1, highSpeed: 2 },

src/services/bundleAnalysis/useBundleAssets.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ const AssetMeasurementsSchema = z.object({
5252

5353
const BundleAssetSchema = z.object({
5454
name: z.string(),
55+
routes: z.array(z.string()).nullable(),
5556
extension: z.string(),
5657
bundleData: BundleDataSchema,
5758
measurements: AssetMeasurementsSchema.nullable(),
@@ -151,6 +152,7 @@ query BundleAssets(
151152
edges {
152153
node {
153154
name
155+
routes
154156
extension
155157
bundleData {
156158
loadTime {

0 commit comments

Comments
 (0)