Skip to content

Commit f584fec

Browse files
authored
Merge pull request #302 from codecrafters-io/andy/tweak
Make it even clearer that the empty RDB file needs to be in binary
2 parents 4d28be7 + 3e50b05 commit f584fec

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

course-definition.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1376,7 +1376,7 @@ stages:
13761376
The file is sent using the following format:
13771377
13781378
```
1379-
$<length_of_file>\r\n<contents_of_file>
1379+
$<length_of_file>\r\n<binary_contents_of_file>
13801380
```
13811381
13821382
(This is similar to how [Bulk Strings](https://redis.io/topics/protocol#resp-bulk-strings) are encoded, but without the trailing `\r\n`)
@@ -1404,7 +1404,7 @@ stages:
14041404
of the file. You need to decode these into binary contents before sending it to the replica.
14051405
- The RDB file should be sent like this: `$<length>\r\n<contents>`
14061406
- `<length>` is the length of the file in bytes
1407-
- `<contents>` is the contents of the file
1407+
- `<contents>` is the binary contents of the file
14081408
- Note that this is NOT a RESP bulk string, it doesn't contain a `\r\n` at the end
14091409
- If you want to learn more about the RDB file format, read [this blog post](https://rdb.fnordig.de/file_format.html). This challenge
14101410
has a separate extension dedicated to reading RDB files.

0 commit comments

Comments
 (0)