Merge pull request #2831 from codecrafters-io/remove-fold-gutter-from-cards

refactor: remove foldGutter property from templates and components

Author: rohitpaulk

app/components/file-contents-card.hbs

@@ -52,7 +52,6 @@
       @rectangularSelection={{true}}
       @editable={{false}}
       @readOnly={{true}}
-      @foldGutter={{if (eq @foldGutter false) false true}}
       @highlightActiveLine={{false}}
       @highlightSelectionMatches={{true}}
       @highlightSpecialChars={{true}}

app/components/file-contents-card.ts

@@ -22,10 +22,6 @@ interface Signature {
      * Override language auto-detected from `filename` and set it manually
      */
     language: string;
-    /**
-     * Enable code folding and fold gutter in CodeMirror
-     */
-    foldGutter?: boolean;
     /**
      * Enable collapsing of the file card to just the header
      */

app/controllers/demo/file-contents-card.ts

@@ -4,7 +4,6 @@ import { tracked } from '@glimmer/tracking';
 import EXAMPLE_DOCUMENTS, { ExampleDocument } from 'codecrafters-frontend/utils/code-mirror-documents';
 
 const OPTION_DEFAULTS = {
-  foldGutter: true,
   headerTooltipText: false,
   isCollapsed: false,
   isCollapsible: false,
@@ -13,11 +12,9 @@ const OPTION_DEFAULTS = {
 };
 
 export default class DemoFileContentsCardController extends Controller {
-  queryParams = ['foldGutter', 'headerTooltipText', 'isCollapsed', 'isCollapsible', 'scrollIntoViewOnCollapse', 'selectedDocumentIndex'];
+  queryParams = ['headerTooltipText', 'isCollapsed', 'isCollapsible', 'scrollIntoViewOnCollapse', 'selectedDocumentIndex'];
 
   @tracked documents: ExampleDocument[] = EXAMPLE_DOCUMENTS;
-
-  @tracked foldGutter: boolean = OPTION_DEFAULTS.foldGutter;
   @tracked headerTooltipText: boolean = OPTION_DEFAULTS.headerTooltipText;
   @tracked isCollapsed: boolean = OPTION_DEFAULTS.isCollapsed;
   @tracked isCollapsible: boolean = OPTION_DEFAULTS.isCollapsible;

app/templates/course-admin/buildpack.hbs

@@ -37,7 +37,6 @@
       @filename="{{@model.buildpack.slug}}.Dockerfile"
       @code={{@model.buildpack.dockerfileContents}}
       @language="dockerfile"
-      @foldGutter={{false}}
       data-test-dockerfile-contents-card
     />
   </div>

app/templates/demo/file-contents-card.hbs

@@ -29,10 +29,6 @@
         <Input @type="checkbox" @checked={{this.headerTooltipText}} disabled={{not this.isCollapsible}} />
         <span class="ml-2 {{unless this.isCollapsible 'text-gray-300'}}">headerTooltipText</span>
       </label>
-      <label class="{{labelClasses}}" title="Enable code folding and fold gutter in CodeMirror">
-        <Input @type="checkbox" @checked={{this.foldGutter}} />
-        <span class="ml-2">foldGutter</span>
-      </label>
     </component-options-right>
   </component-options>
 {{/let}}
@@ -45,7 +41,6 @@
   @isCollapsible={{this.isCollapsible}}
   @scrollIntoViewOnCollapse={{this.scrollIntoViewOnCollapse}}
   @headerTooltipText={{if this.headerTooltipText "Example tooltip message"}}
-  @foldGutter={{this.foldGutter}}
   @onExpand={{fn (mut this.isCollapsed) false}}
   @onCollapse={{fn (mut this.isCollapsed) true}}
   class="mt-4"

tests/acceptance/demo-page/file-contents-card-test.js

@@ -100,13 +100,4 @@ module('Acceptance | demo page | file-contents-card', function (hooks) {
       'correct tooltip message is displayed',
     );
   });
-
-  test("it allows toggling 'foldGutter' option", async function (assert) {
-    await demoPage.demoTabs.fileContentsCard.visit();
-    assert.ok(demoPage.demoTabs.fileContentsCard.component.codeMirror.gutters.foldGutter.isVisible, 'fold gutter is present');
-    await demoPage.demoTabs.fileContentsCard.clickOnComponentOption('foldGutter');
-    assert.notOk(demoPage.demoTabs.fileContentsCard.component.codeMirror.gutters.foldGutter.isVisible, 'fold gutter is not present');
-    await demoPage.demoTabs.fileContentsCard.clickOnComponentOption('foldGutter');
-    assert.ok(demoPage.demoTabs.fileContentsCard.component.codeMirror.gutters.foldGutter.isVisible, 'fold gutter is present again');
-  });
 });