Skip to content

Commit ec3845e

Browse files
sarupbanskotaclaude
andcommitted
fix: ensure data-test-github-name is always present in member rows
The page object collection iterates all members and accesses githubName text(), which throws when the element is missing. Always render data-test-github-name so the collection doesn't error on members who only have a username. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 9bace60 commit ec3845e

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

  • app/components/team-page/members-table

app/components/team-page/members-table/row.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
<div class="min-w-0 flex items-center gap-1">
77
<span class="text-gray-700 text-sm font-semibold truncate max-w-[130px] inline-block align-middle">
88
{{#if @membership.user.githubName}}
9-
<span data-test-github-name>{{@membership.user.githubName}}</span>
9+
<span data-test-github-name data-test-username>{{@membership.user.githubName}}</span>
1010
{{else}}
11-
<span data-test-username>{{@membership.user.username}}</span>
11+
<span data-test-github-name data-test-username>{{@membership.user.username}}</span>
1212
{{/if}}
1313
</span>
1414
{{#if @membership.isAdmin}}

0 commit comments

Comments
 (0)