refactor: standardize FEN handling and improve logging in test functions

Author: ryan-gang

Diff for: internal/assertions/valid_move_assertion.go

@@ -29,9 +29,16 @@ func (a *ValidMoveAssertion) Run(response *http.Response, logger *logger.Logger)
 }
 
 func moveIsValid(fenStr string, move string) bool {
-	fen, err := chess.FEN(fenStr)
+	var fen func(*chess.Game)
+	var err error
+
+	fen, err = chess.FEN(fenStr)
 	if err != nil {
-		return false
+		fenStr += " 0 1"
+		fen, err = chess.FEN(fenStr)
+		if err != nil {
+			return false
+		}
 	}
 
 	game := chess.NewGame(fen)

Diff for: internal/stage_4.go

@@ -3,6 +3,7 @@ package internal
 import (
 	chess_bot_executable "github.com/codecrafters-io/gleam-chess-bot-tester/internal/chess-bot-executable"
 	"github.com/codecrafters-io/gleam-chess-bot-tester/internal/test_cases"
+	"github.com/codecrafters-io/tester-utils/random"
 	"github.com/codecrafters-io/tester-utils/test_case_harness"
 )
 
@@ -41,11 +42,12 @@ func test4(stageHarness *test_case_harness.TestCaseHarness) error {
 		"r2qnrnk/p2b2b1/1p1p2pp/2pPpp2/1PP1P3/PRNBB3/3QNPPP/5RK1 w - -",
 	}
 
-	for i, FEN := range FENs {
+	POSITIONS := 3
+	for i, FEN := range random.RandomElementsFromArray(FENs, POSITIONS) {
 		if !checkFEN(FEN) {
 			continue
 		}
-		stageHarness.Logger.Infof("%d/%d RUN Generate Chess Move for Position: %s", i+1, len(FENs), FEN)
+		stageHarness.Logger.Infof("%d/%d RUN Generate Chess Move for Position: %s", i+1, POSITIONS, FEN)
 
 		test_case := test_cases.GetMoveTestCase{
 			FEN:                        FEN,

Diff for: internal/stage_5.go

@@ -174,11 +174,12 @@ func test5(stageHarness *test_case_harness.TestCaseHarness) error {
 		"qn1kr2r/1pRbb3/pP5p/P2pP1pP/3N1pQ1/3B4/3B1PP1/R5K1 w - - 0 1",
 	}
 
-	for i, FEN := range random.RandomElementsFromArray(FENs, 4) {
+	POSITIONS := 4
+	for i, FEN := range random.RandomElementsFromArray(FENs, POSITIONS) {
 		if !checkFEN(FEN) {
 			continue
 		}
-		stageHarness.Logger.Infof("%d/%d RUN Generate Chess Move for Position: %s", i+1, len(FENs), FEN)
+		stageHarness.Logger.Infof("%d/%d RUN Generate Chess Move for Position: %s", i+1, POSITIONS, FEN)
 
 		testCase := test_cases.GetMoveTestCase{
 			FEN:                        FEN,

Diff for: internal/test_cases/send_request_test_case.go

@@ -43,7 +43,7 @@ func (tc *SendRequestTestCase) Run(logger *logger.Logger) error {
 	if duration > 5*time.Second {
 		return fmt.Errorf("request took too long to complete: %s", duration)
 	}
-	logger.Debugf("Request completed in %s", duration)
+	// logger.Debugf("Request completed in %s", duration)
 
 	// Run the assertion
 	if tc.Assertion != nil {

Diff for: internal/utils.go

@@ -71,5 +71,9 @@ func makeMove(fenStr string) (string, error) {
 
 func checkFEN(FEN string) bool {
 	_, err := chess.FEN(FEN)
+	if err != nil {
+		FEN += " 0 1"
+		_, err = chess.FEN(FEN)
+	}
 	return err == nil
 }