Skip to content

Commit a775d9a

Browse files
committed
2.x: Fixed version in controller-manager.ts
1 parent 9a05911 commit a775d9a

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

.github/workflows/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ Builds base and controller images using the contents of the `devel` branch on pu
88
To test a `devel` container on a project, firstly fetch the container image:
99

1010
```
11-
docker pull codeenigma/ce-dev-controller-2.x:devel
11+
docker pull codeenigma/ce-dev-controller:2.x
1212
```
1313

1414
Then edit your project's `ce-dev.compose.yml` file, changing the image for each applicable service to use the `devel` tag instead of the `latest` tag, for example:
1515

1616
```yaml
17-
image: codeenigma/ce-dev-2.x:devel
17+
image: codeenigma/ce-dev:2.x
1818
```
1919
2020
Finally, destroy and recreate your `docker compose` file and containers:
@@ -31,9 +31,9 @@ ce-dev deploy
3131
To test the `devel` version of the `ce-dev-controller` image locally you can do the following:
3232

3333
```bash
34-
docker pull codeenigma/ce-dev-controller-2.x:devel
34+
docker pull codeenigma/ce-dev-controller:2.x-devel
3535
# Replace the 'latest' tag with your 'devel' image
36-
docker tag codeenigma/ce-dev-controller-2.x:devel codeenigma/ce-dev-controller-2.x:latest
36+
docker tag codeenigma/ce-dev-controller:2.x-devel codeenigma/ce-dev-controller:2.x
3737
docker kill ce_dev_controller
3838
# Then in any ce-dev project
3939
ce-dev start

src/controller-manager.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -248,20 +248,20 @@ export default class ControllerManager {
248248
*/
249249
public pullImage(): void {
250250
// If in development mode, we use devel version.
251-
let version = 'latest'
251+
let version = AppSettings.ceDevVersion + '.x';
252252
if (this.developmentMode) {
253-
version = 'devel'
253+
version = '-devel';
254254
}
255-
execSync(this.dockerBin + ' pull codeenigma/ce-dev-controller-' + AppSettings.ceDevVersion + '.x:' + version, {
255+
execSync(this.dockerBin + ' pull codeenigma/ce-dev-controller:' + version, {
256256
stdio: 'inherit',
257257
})
258258
}
259259

260260
private getControllerConfig(): DockerComposeConfigBare {
261261
const ipManager = new IPManager(this.config, this.dockerBin)
262-
let version = 'latest'
262+
let version = AppSettings.ceDevVersion + '.x'
263263
if (this.developmentMode) {
264-
version = 'devel'
264+
version = '-devel'
265265
}
266266
return {
267267
networks: {
@@ -275,7 +275,7 @@ export default class ControllerManager {
275275
cgroup: 'host',
276276
container_name: 'ce_dev_controller',
277277
hostname: 'ce_dev_controller',
278-
image: 'codeenigma/ce-dev-controller-'+ AppSettings.ceDevVersion + '.x:' + version,
278+
image: 'codeenigma/ce-dev-controller:' + version,
279279
networks: {
280280
ce_dev: {
281281
ipv4_address: ipManager.getControllerIP(),

0 commit comments

Comments
 (0)