Check for duplicates before submitting data in backend

[bezin]

Hello there,

thanks for this awesome bundle. I implemented in a recent project and I am most pleased :-)

I experienced one UX issue while editing some content: I entered a couple of tags to a dataset from a list my client gave me. I did not realize the list contained some duplicates.

What happened

• Enter Chai => Tag does not exist yet => Add Chai =>Chai is added to the tags list

• Continue enter plenty more tags.

• Save in between.

• Enter Chai again => Tag is already in list and does exist in Database, but selectize.js does not check that -> Add Chai -> Chai is added to the tags list.

• Chai is added two times now

• On submit, an SQL error will be thrown: When the bundle tries to add the second Chai, the first one is already stored in the database:

An exception occurred while executing 'INSERT INTO tl_cfg_tag (`tstamp`, `name`, `source`) VALUES (1554295030, 'Chai', 'app.trader_tags')':

SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'Chai-app.trader_tags' for key 'name_source'

This is quite annoying from an UX perspective.

What should happen

• I would expect a duplicate check whether the given term was already entered before
• I would than expect a message like "Tag already in list"

What do you think? I could provide a PR.

Cheerio

EDIT: I edited this issue to be more precisely: If a term is not saved yet, you cannot add it twice to the tags list. Selectize.js takes care of that. However, if you saved once, you can easily add an already added and saved tag multiple times, causing the SQL Expection.

[bezin]

I tracked this further down:

The issue lies here:

tags-bundle/src/Resources/public/selectize.js

Lines 2581 to 2584 in 5fca404

	if (self.items.indexOf(value) !== -1) {
	if (inputMode === 'single') self.close();
	return;
	}

and here:

tags-bundle/src/Resources/public/widget.js

Lines 78 to 83 in 5fca404

	options.create = function (input) {
	return {
	value: input,
	text: input
	}
	};

The selectize.js duplicate check looks for values; if we add Chai for the second time, it will be added with an value of Chai. The first Chai item is in the list with value of the corresponding id e.g. 123. Hence it will be added twice.

I therefore suggest, to check here, whether there already is a tag with the same name and source before finally returning null and creating a new tag.

tags-bundle/src/Manager/DefaultManager.php

Lines 91 to 93 in 5fca404

	if (null === ($model = $adapter->findByPk($value))) {
	return null;
	}

[qzminski]

Hey, sorry for the super late reply… I'd be very glad if you can provide a PR!

[frontendschlampe]

@bezin do you will provide any PR? ;-)