feat: wire PiiMasker into both repositories for email, phone, and address

Author: adbergen

src/SEBT.Portal.Infrastructure/Repositories/HouseholdRepository.cs

@@ -105,7 +105,15 @@ private static HouseholdData ApplyPiiVisibility(HouseholdData source, PiiVisibil
                     State = source.AddressOnFile.State,
                     PostalCode = source.AddressOnFile.PostalCode
                 }
-                : null
+                : source.AddressOnFile != null
+                    ? new Address
+                    {
+                        StreetAddress1 = PiiMasker.MaskStreetAddress(source.AddressOnFile.StreetAddress1, source.AddressOnFile.StreetAddress2),
+                        City = source.AddressOnFile.City,
+                        State = source.AddressOnFile.State,
+                        PostalCode = source.AddressOnFile.PostalCode
+                    }
+                    : null
         };
     }
 

src/SEBT.Portal.Infrastructure/Repositories/MockHouseholdRepository.cs

@@ -475,8 +475,8 @@ private static HouseholdData CreateCopy(HouseholdData source, PiiVisibility piiV
     {
         return source with
         {
-            Email = piiVisibility.IncludeEmail ? source.Email : null,
-            Phone = piiVisibility.IncludePhone ? source.Phone : null,
+            Email = piiVisibility.IncludeEmail ? source.Email : PiiMasker.MaskEmail(source.Email),
+            Phone = piiVisibility.IncludePhone ? source.Phone : PiiMasker.MaskPhone(source.Phone),
             AddressOnFile = piiVisibility.IncludeAddress && source.AddressOnFile != null
                 ? new Address
                 {
@@ -486,7 +486,15 @@ private static HouseholdData CreateCopy(HouseholdData source, PiiVisibility piiV
                     State = source.AddressOnFile.State,
                     PostalCode = source.AddressOnFile.PostalCode
                 }
-                : null,
+                : source.AddressOnFile != null
+                    ? new Address
+                    {
+                        StreetAddress1 = PiiMasker.MaskStreetAddress(source.AddressOnFile.StreetAddress1, source.AddressOnFile.StreetAddress2),
+                        City = source.AddressOnFile.City,
+                        State = source.AddressOnFile.State,
+                        PostalCode = source.AddressOnFile.PostalCode
+                    }
+                    : null,
             BenefitIssuanceType = source.BenefitIssuanceType,
             UserProfile = source.UserProfile != null
                 ? new UserProfile

test/SEBT.Portal.Tests/Unit/Repositories/HouseholdRepositoryTests.cs

@@ -168,7 +168,7 @@ public async Task GetHouseholdByEmailAsync_WhenPiiExcludesPhone_ReturnsMaskedPho
     }
 
     [Fact]
-    public async Task GetHouseholdByEmailAsync_WhenPiiExcludesAddress_ReturnsNullAddress()
+    public async Task GetHouseholdByEmailAsync_WhenPiiExcludesAddress_ReturnsMaskedAddress()
     {
         _summerEbtCaseService
             .GetHouseholdByGuardianEmailAsync(Arg.Any<string>(), Arg.Any<PluginPiiVisibility>(), Arg.Any<PluginIdentityAssuranceLevel>(), Arg.Any<CancellationToken>())
@@ -191,7 +191,12 @@ public async Task GetHouseholdByEmailAsync_WhenPiiExcludesAddress_ReturnsNullAdd
         var result = await _repository.GetHouseholdByEmailAsync("u@e.com", noAddressPii, UserIalLevel.IAL1plus);
 
         Assert.NotNull(result);
-        Assert.Null(result.AddressOnFile);
+        Assert.NotNull(result.AddressOnFile);
+        Assert.Equal("****", result.AddressOnFile.StreetAddress1);
+        Assert.Null(result.AddressOnFile.StreetAddress2);
+        Assert.Equal("Denver", result.AddressOnFile.City);
+        Assert.Equal("CO", result.AddressOnFile.State);
+        Assert.Equal("80202", result.AddressOnFile.PostalCode);
     }
 
     [Fact]

test/SEBT.Portal.Tests/Unit/Repositories/MockHouseholdRepositoryTests.cs

@@ -180,7 +180,7 @@ public async Task GetHouseholdByEmailAsync_WhenIncludeAddressIsTrue_ReturnsAddre
     }
 
     [Fact]
-    public async Task GetHouseholdByEmailAsync_WhenIncludeAddressIsFalse_DoesNotReturnAddress()
+    public async Task GetHouseholdByEmailAsync_WhenIncludeAddressIsFalse_ReturnsMaskedAddress()
     {
         // Arrange
         var email = "verified@example.com";
@@ -190,7 +190,9 @@ public async Task GetHouseholdByEmailAsync_WhenIncludeAddressIsFalse_DoesNotRetu
 
         // Assert
         Assert.NotNull(result);
-        Assert.Null(result.AddressOnFile);
+        Assert.NotNull(result.AddressOnFile);
+        Assert.Equal("****", result.AddressOnFile.StreetAddress1);
+        Assert.Equal("Denver", result.AddressOnFile.City);
     }
 
     [Fact]
@@ -429,7 +431,7 @@ public async Task GetHouseholdByEmailAsync_MinimalScenario_HasCorrectData()
     }
 
     [Fact]
-    public async Task GetHouseholdByEmailAsync_WhenIncludeEmailFalse_ReturnsEmptyEmail()
+    public async Task GetHouseholdByEmailAsync_WhenIncludeEmailFalse_ReturnsMaskedEmail()
     {
         // Arrange
         var email = "verified@example.com";
@@ -440,15 +442,15 @@ public async Task GetHouseholdByEmailAsync_WhenIncludeEmailFalse_ReturnsEmptyEma
 
         // Assert
         Assert.NotNull(result);
-        Assert.Null(result.Email);
+        Assert.Equal("v***@example.com", result.Email);
         Assert.NotNull(result.Phone);
     }
 
     [Fact]
-    public async Task GetHouseholdByEmailAsync_WhenIncludePhoneFalse_ReturnsNullPhone()
+    public async Task GetHouseholdByEmailAsync_WhenIncludePhoneFalse_ReturnsMaskedPhone()
     {
-        // Arrange
-        var email = "verified@example.com";
+        // Arrange — non-co-loaded scenario has an explicit phone number
+        var email = "non-co-loaded@example.com";
         var noPhoneVisibility = new PiiVisibility(IncludeAddress: true, IncludeEmail: true, IncludePhone: false);
 
         // Act
@@ -457,7 +459,7 @@ public async Task GetHouseholdByEmailAsync_WhenIncludePhoneFalse_ReturnsNullPhon
         // Assert
         Assert.NotNull(result);
         Assert.Equal(email, result.Email);
-        Assert.Null(result.Phone);
+        Assert.Equal("***-***-4567", result.Phone);
     }
 
     [Fact]