fix: align address PII visibility with existing null-address contract

Author: adbergen

src/SEBT.Portal.Infrastructure/Repositories/HouseholdRepository.cs

@@ -96,26 +96,15 @@ private static HouseholdData ApplyPiiVisibility(HouseholdData source, PiiVisibil
         {
             Email = piiVisibility.IncludeEmail ? source.Email : PiiMasker.MaskEmail(source.Email),
             Phone = piiVisibility.IncludePhone ? source.Phone : PiiMasker.MaskPhone(source.Phone),
-            AddressOnFile = source.AddressOnFile != null
-                ? piiVisibility.IncludeAddress
-                    ? new Address
-                    {
-                        StreetAddress1 = source.AddressOnFile.StreetAddress1,
-                        StreetAddress2 = source.AddressOnFile.StreetAddress2,
-                        City = source.AddressOnFile.City,
-                        State = source.AddressOnFile.State,
-                        PostalCode = source.AddressOnFile.PostalCode
-                    }
-                    : new Address
-                    {
-                        StreetAddress1 = PiiMasker.MaskStreetAddress(
-                            source.AddressOnFile.StreetAddress1,
-                            source.AddressOnFile.StreetAddress2),
-                        StreetAddress2 = null,
-                        City = source.AddressOnFile.City,
-                        State = source.AddressOnFile.State,
-                        PostalCode = source.AddressOnFile.PostalCode
-                    }
+            AddressOnFile = piiVisibility.IncludeAddress && source.AddressOnFile != null
+                ? new Address
+                {
+                    StreetAddress1 = source.AddressOnFile.StreetAddress1,
+                    StreetAddress2 = source.AddressOnFile.StreetAddress2,
+                    City = source.AddressOnFile.City,
+                    State = source.AddressOnFile.State,
+                    PostalCode = source.AddressOnFile.PostalCode
+                }
                 : null
         };
     }

test/SEBT.Portal.Tests/Unit/Repositories/HouseholdRepositoryTests.cs

@@ -168,7 +168,7 @@ public async Task GetHouseholdByEmailAsync_WhenPiiExcludesPhone_ReturnsMaskedPho
     }
 
     [Fact]
-    public async Task GetHouseholdByEmailAsync_WhenPiiExcludesAddress_ReturnsMaskedStreetPreservesCityStateZip()
+    public async Task GetHouseholdByEmailAsync_WhenPiiExcludesAddress_ReturnsNullAddress()
     {
         _summerEbtCaseService
             .GetHouseholdByGuardianEmailAsync(Arg.Any<string>(), Arg.Any<PluginPiiVisibility>(), Arg.Any<PluginIdentityAssuranceLevel>(), Arg.Any<CancellationToken>())
@@ -191,14 +191,7 @@ public async Task GetHouseholdByEmailAsync_WhenPiiExcludesAddress_ReturnsMaskedS
         var result = await _repository.GetHouseholdByEmailAsync("u@e.com", noAddressPii, UserIalLevel.IAL1plus);
 
         Assert.NotNull(result);
-        Assert.NotNull(result.AddressOnFile);
-        // Street lines are masked
-        Assert.DoesNotContain("123 Main St", result.AddressOnFile.StreetAddress1);
-        Assert.Null(result.AddressOnFile.StreetAddress2);
-        // City, state, zip are preserved
-        Assert.Equal("Denver", result.AddressOnFile.City);
-        Assert.Equal("CO", result.AddressOnFile.State);
-        Assert.Equal("80202", result.AddressOnFile.PostalCode);
+        Assert.Null(result.AddressOnFile);
     }
 
     [Fact]