review comments

Author: aloverso

spec/lib/pdf_filler/nj1040_pdf_spec.rb

@@ -1615,20 +1615,22 @@
 
     describe "line 55 - total income tax withheld" do
       context 'when TaxWithheld has a value' do
-        let(:intake) { create(:state_file_nj_intake, :df_data_many_w2s) }
+        before do
+          allow_any_instance_of(Efile::Nj::Nj1040Calculator).to receive(:calculate_line_55).and_return 12_345_678
+        end
 
         it "fills line 55 with sum of income tax withheld" do
           # millions
-          expect(pdf_fields["undefined_1471qerw"]).to eq ""
-          expect(pdf_fields["undefined_114"]).to eq ""
+          expect(pdf_fields["undefined_1471qerw"]).to eq "1"
+          expect(pdf_fields["undefined_114"]).to eq "2"
           # thousands
-          expect(pdf_fields["undefined_143"]).to eq ""
-          expect(pdf_fields["undefined_144"]).to eq ""
-          expect(pdf_fields["undefined_145"]).to eq "2"
+          expect(pdf_fields["undefined_143"]).to eq "3"
+          expect(pdf_fields["undefined_144"]).to eq "4"
+          expect(pdf_fields["undefined_145"]).to eq "5"
           # hundreds
-          expect(pdf_fields["Text153"]).to eq "0"
-          expect(pdf_fields["Text154"]).to eq "0"
-          expect(pdf_fields["Text155"]).to eq "0"
+          expect(pdf_fields["Text153"]).to eq "6"
+          expect(pdf_fields["Text154"]).to eq "7"
+          expect(pdf_fields["Text155"]).to eq "8"
           # decimals
           expect(pdf_fields["Text156"]).to eq "0"
           expect(pdf_fields["Text157"]).to eq "0"

spec/lib/submission_builder/ty2024/states/nj/documents/nj1040_spec.rb

@@ -761,10 +761,11 @@
 
     describe "total income tax withheld - line 55" do
       context 'when has w2s' do
-        let(:intake) { create(:state_file_nj_intake, :df_data_many_w2s)}
+        before do
+          allow_any_instance_of(Efile::Nj::Nj1040Calculator).to receive(:calculate_line_55).and_return 12_345
+        end
         it 'sets TaxWithheld to sum of state_income_tax_amount' do
-          expected = 2000 # 500 + 500 + 500 + 500
-          expect(xml.at("TaxWithheld").text).to eq(expected.to_s)
+          expect(xml.at("TaxWithheld").text).to eq(12_345.to_s)
         end
       end