Nj 366 dep health ins (#6071)

Change logic to show NJ health insurance question to anyone with dependents, update copy to current year

Author: mmazanec22

app/controllers/state_file/questions/nj_dependents_health_insurance_controller.rb

@@ -3,7 +3,7 @@ module Questions
     class NjDependentsHealthInsuranceController < QuestionsController
 
       def self.show?(intake)
-        intake.dependents.any? && intake.has_health_insurance_requirement_exception?
+        intake.dependents.any?
       end
 
       def form_params

app/views/state_file/questions/nj_dependents_health_insurance/edit.html.erb

@@ -1,4 +1,4 @@
-<% title = t(".title_html", filing_year: current_tax_year) %>
+<% title = t(".title_html", current_year: current_tax_year + 1) %>
 
 <% content_for :page_title, ActionView::Base.full_sanitizer.sanitize(title) %>
 <% content_for :card do %>

config/locales/en.yml

@@ -3733,8 +3733,8 @@ en:
         edit:
           continue: Click "Continue" if all these people had health insurance.
           coverage_heading: What is health insurance with minimum essential coverage?
-          label: 'Check all the people that did NOT have health insurance:'
-          title_html: Please tell us which dependents were missing health insurance (<a target=" _blank" rel="noopener noreferrer" href="https://nj.gov/treasury/njhealthinsurancemandate/getinfo.shtml">with minimum essential health coverage</a>) in %{filing_year}.
+          label: 'Check all the dependents that do NOT have health insurance:'
+          title_html: In %{current_year}, who in your tax household doesn’t have health insurance with <a target=" _blank" rel="noopener noreferrer" href="https://nj.gov/treasury/njhealthinsurancemandate/getinfo.shtml">Minimum Essential Coverage?</a>
       nj_disabled_exemption:
         edit:
           instructions_html: "<p>In New Jersey, you are considered disabled if you have a \"<strong>total and permanent</strong> inability to engage in any substantial gainful activity because of any physical or mental impairment, including blindness.\"</p>  \n<p>(This is different from the federal tax definition. New Jersey doesn’t consider your age or your receipt of taxable disability income.)</p>\n"

config/locales/es.yml

@@ -3709,8 +3709,8 @@ es:
         edit:
           continue: Haz clic en "Continuar" si todas estas personas tenían seguro médico.
           coverage_heading: "¿Qué es el seguro de salud con cobertura mínima esencial?"
-          label: 'Marca todas las personas que NO tuvieron seguro médico:'
-          title_html: Por favor, dinos qué dependientes no tuvieron seguro médico (<a target=" _blank" rel="noopener noreferrer" href="https://nj.gov/treasury/njhealthinsurancemandate/getinfo.shtml">con cobertura médica mínima esencial</a>) en %{filing_year}.
+          label: 'Marca a todas las personas dependientes que NO tienen seguro de salud:'
+          title_html: ¿En %{current_year}, quién en tu hogar tributario/fiscal no tiene seguro de salud con <a target=" _blank" rel="noopener noreferrer" href="https://nj.gov/treasury/njhealthinsurancemandate/getinfo.shtml">Cobertura Esencial Mínima?</a>
       nj_disabled_exemption:
         edit:
           instructions_html: "<p>En New Jersey, se considera que una persona tiene una discapacidad si tiene una \"incapacidad <strong>total y permanente</strong> para realizar cualquier actividad lucrativa sustancial debido a cualquier discapacidad física o mental, incluida la ceguera.\"</p>  \n<p>(Esto es diferente de la definición de impuestos federales. New Jersey no considera tu edad ni la recepción de ingresos por discapacidad imponibles).</p>\n"

spec/controllers/state_file/questions/nj_dependents_health_insurance_controller_spec.rb

@@ -2,11 +2,9 @@
 
 RSpec.describe StateFile::Questions::NjDependentsHealthInsuranceController do
   describe ".show?" do
-    context "when intake has no dependents but would otherwise meet the criteria to show the controller" do
+    context "when intake has no dependents" do
       let(:intake) { create :state_file_nj_intake, :df_data_minimal}
       it "does not show" do
-        allow_any_instance_of(StateFileNjIntake).to receive(:has_health_insurance_requirement_exception?).and_return(true)
-        allow_any_instance_of(StateFileNjIntake).to receive(:eligibility_all_members_health_insurance_no?).and_return(true)
         expect(described_class.show?(intake)).to eq false
       end
     end
@@ -15,10 +13,10 @@
       let(:intake) { create :state_file_nj_intake, :df_data_two_deps }
 
       context "and did not have a health insurance requirement exception and all members had health insurance" do
-        it "does not show" do
+        it "shows" do
           allow_any_instance_of(StateFileNjIntake).to receive(:has_health_insurance_requirement_exception?).and_return(false)
           allow_any_instance_of(StateFileNjIntake).to receive(:eligibility_all_members_health_insurance_no?).and_return(false)
-          expect(described_class.show?(intake)).to eq false
+          expect(described_class.show?(intake)).to eq true
         end
       end
 

spec/features/state_file/nj/complete_intake_spec.rb

@@ -110,6 +110,11 @@ def advance_college_dependents(selection = false)
       continue
     end
 
+    def advance_dependents_health_insurance
+      page_change_check(I18n.t("state_file.questions.nj_dependents_health_insurance.edit.label"))
+      continue
+    end
+
     def advance_medical_expenses(amount: 1000)
       page_change_check("You may be able to deduct medical expenses.")
       fill_in I18n.t('state_file.questions.nj_medical_expenses.edit.label', filing_year: filing_year), with: amount
@@ -244,6 +249,9 @@ def advance_to_property_tax_page(skip_health_insurance_eligibility: false)
       if has_text? I18n.t("state_file.questions.nj_college_dependents_exemption.edit.title")
         advance_college_dependents
       end
+      if has_text? I18n.t("state_file.questions.nj_dependents_health_insurance.edit.label")
+        advance_dependents_health_insurance
+      end
       advance_medical_expenses
     end
 
@@ -279,6 +287,11 @@ def check_xml_results
         expect(page).to be_axe_clean
         advance_college_dependents
       end
+
+      page_change_block do
+        expect(page).to be_axe_clean
+        advance_dependents_health_insurance
+      end
 
       page_change_block do
         expect(page).to be_axe_clean