Merge remote-tracking branch 'origin/main' into FYST-2263-create-oct-21-df-reminder-notification

Author: embarnard

app/models/state_file/automated_message/october_transfer_reminder.rb

@@ -0,0 +1,28 @@
+module StateFile::AutomatedMessage
+  class OctoberTransferReminder < BaseAutomatedMessage
+
+    def self.after_transition_notification?
+      false
+    end
+
+    def self.send_only_once?
+      true
+    end
+
+    def self.name
+      'messages.state_file.october_transfer_reminder'.freeze
+    end
+
+    def sms_body(**args)
+      I18n.t("messages.state_file.october_transfer_reminder.sms", **args)
+    end
+
+    def email_subject(**args)
+      I18n.t("messages.state_file.october_transfer_reminder.email.subject", **args)
+    end
+
+    def email_body(**args)
+      I18n.t("messages.state_file.october_transfer_reminder.email.body", **args)
+    end
+  end
+end

app/models/state_file_base_intake.rb

@@ -92,6 +92,26 @@ def self.selected_intakes_for_deadline_reminder_notifications
       .select(&:should_be_sent_reminder?)
   end
 
+  def self.selected_intakes_for_first_deadline_reminder_notification
+    self.where(df_data_imported_at: nil)
+        .has_verified_contact_info
+        .where(created_at: Time.current.beginning_of_year..Time.current.end_of_year)
+        .select(&:send_october_transfer_reminder?)
+  end
+
+  def send_october_transfer_reminder?
+    received_message_recently = if message_tracker.present?
+                                  message_tracker.values.compact.any? do |time_msg_sent|
+                                    next false if time_msg_sent.blank?
+                                    Time.parse(time_msg_sent.to_s) > 24.hours.ago
+                                  end
+                                else
+                                  false
+                                end
+
+    !received_message_recently && !other_intake_with_same_ssn_has_submission?
+  end
+
   def should_be_sent_reminder?
     received_reminder_recently = if message_tracker.present? && message_tracker["messages.state_file.finish_return"]
                                    finish_return_msg_sent_time = Time.parse(message_tracker["messages.state_file.finish_return"])

app/services/state_file/october_transfer_reminder_service.rb

@@ -0,0 +1,21 @@
+module StateFile
+  class OctoberTransferReminderService
+    BATCH_SIZE = 100
+
+    def self.run
+      intakes_to_notify = []
+      StateFile::StateInformationService.state_intake_classes.excluding(StateFileNyIntake).each do |class_object|
+        intakes_to_notify += class_object.selected_intakes_for_first_deadline_reminder_notification
+      end
+
+      intakes_to_notify.each_slice(BATCH_SIZE) do |batch|
+        batch.each do |intake|
+          StateFile::MessagingService.new(
+            message: StateFile::AutomatedMessage::OctoberTransferReminder,
+            intake: intake
+          ).send_message
+        end
+      end
+    end
+  end
+end

app/views/signups/new.html.erb

@@ -3,7 +3,7 @@
     <div class="slab slab--banner">
       <div class="grid">
         <div class="grid__item">
-          <strong><%= t('.banner') %></strong>
+          <strong><%= t('.banner', year: app_time.year) %></strong>
         </div>
       </div>
     </div>

config/locales/en.yml

@@ -1732,6 +1732,28 @@ en:
             The FileYourStateTaxes team
           subject: Remember to finish your state tax return
         sms: "Hi %{primary_first_name} - You started a state tax return with FileYourStateTaxes but have not finished. \n\nGo to http://www.fileyourstatetaxes.org/en/login-options to finish them today. The last day to submit your state tax return is October 22.\n\nIf you have already filed using another service, no action is required.\n\nNeed help? Email us at [email protected]\n\nBest,\nThe FileYourStateTaxes team\n"
+      october_transfer_reminder:
+        email:
+          body: |
+            Hi!
+
+            It looks like you created an account with <a target="_blank" rel="noopener nofollow" href="https://www.fileyourstatetaxes.org/">FileYourStateTaxes</a> but haven't transferred your federal return information from IRS Direct File. If you want to file your state return with us, please do so before October 22nd.
+
+            It's easy! Get started now at <a target="_blank" rel="noopener nofollow" href="https://www.fileyourstatetaxes.org/en/login-options">www.fileyourstatetaxes.org/en/login-options</a>.
+
+            Need help? Reply to this email.
+
+            Best,
+            The FileYourStateTaxes team
+          subject: Remember to start your state tax return
+        sms: |
+          Hi!
+
+          It looks like you created an account with FileYourStateTaxes but haven't transferred your federal return information from IRS Direct File. If you want to file your state return with us please do so before October 22nd.
+
+          It's easy! Get started now at http://www.fileyourstatetaxes.org/en/login-options .
+
+          Need help? Email us at [email protected]
       post_deadline_reminder:
         email:
           body: |-
@@ -2208,7 +2230,7 @@ en:
   signups:
     flash_notice: Thank you! You will receive a notification when we open.
     new:
-      banner: New intakes for GetYourRefund have closed for 2023. Please come back in January to file next year.
+      banner: New intakes for GetYourRefund have closed for %{year}. Please come back in January to file next year.
       header: We'd love to work with you next year to help you file your taxes for free!
       opt_in_message:
         01_intro: 'Note: Providing your phone number means you have opted in to the following in order to use the GetYourRefund service:'

config/locales/es.yml

@@ -1713,6 +1713,20 @@ es:
           body: "Hola %{primary_first_name},\n\nTodavía no has enviado tu declaración de impuestos estatales. \n\nCompleta tu declaración hoy visitando <a target=\"_blank\" rel=\"noopener nofollow\" href=\"http://www.fileyourstatetaxes.org/es/login-options\">www.fileyourstatetaxes.org/es/login-options</a>. El último día para enviar tu declaración estatal es el 22 de octubre.\n\nSi ya presentaste tu declaración usando otro servicio, no necesitas hacer nada.\n\n¿Necesitas ayuda? Responde a este correo electrónico.\n\nAtentamente,\nEl equipo de FileYourStateTaxes\n"
           subject: Recuerda terminar tu declaración de impuestos estatales
         sms: "Hola %{primary_first_name} - Aún no has enviado tu declaración de impuestos estatales.\n\nCompleta tu declaración hoy en http://www.fileyourstatetaxes.org/es/login-options . El último día para enviar tu declaración estatal es el 22 de octubre. \n\nSi ya presentaste tu declaración usando otro servicio, no necesitas hacer nada.\n\n¿Necesitas ayuda? Envíanos un email a [email protected].\n\nAtentamente,\nEl equipo de FileYourStateTaxes\n"
+      october_transfer_reminder:
+        email:
+          body: "¡Hola! \n\nAl parecer creaste una cuenta con <a target=\"_blank\" rel=\"noopener nofollow\" href=\"https://www.fileyourstatetaxes.org/\">FileYourStateTaxes</a>, pero aún no has transferido la información de tu declaración federal desde IRS Direct File. Si deseas presentar tu declaración estatal con nosotros, hazlo antes del 22 de octubre.\n\n¡Es fácil! Comienza ahora en <a target=\"_blank\" rel=\"noopener nofollow\" href=\"https://www.fileyourstatetaxes.org/es/login-options\">www.fileyourstatetaxes.org/es/login-options</a>.\n\n¿Necesitas ayuda? Responde a este correo electrónico.\n\nAtentamente, El equipo de FileYourStateTaxes\n"
+          subject: Recuerda comenzar tu declaración de impuestos estatales
+        sms: |
+          ¡Hola!
+
+          Al parecer creaste una cuenta con FileYourStateTaxes, pero aún no has transferido la información de tu declaración federal desde IRS Direct File. Si deseas presentar tu declaración estatal con nosotros, hazlo antes del 22 de octubre.
+
+          Es fácil! Comienza en http://www.fileyourstatetaxes.org/es/login-options .
+
+          ¿Necesitas ayuda? Envíanos un email a [email protected].
+
+          Atentamente, El equipo de FileYourStateTaxes
       post_deadline_reminder:
         email:
           body: |-
@@ -2185,7 +2199,7 @@ es:
   signups:
     flash_notice: "¡Gracias! Recibirás una notificación cuando abramos."
     new:
-      banner: Se cerraron nuevas inscripciones para GetYourRefund para 2023. Vuelva en enero para presentar la solicitud el próximo año.
+      banner: Se cerraron nuevas inscripciones para GetYourRefund para %{year}. Vuelva en enero para presentar la solicitud el próximo año.
       header: "¡Nos daría mucho gusto trabajar con usted y ayudarle gratuitamente a declarar sus impuestos!"
       opt_in_message:
         01_intro: 'Aviso: Proporcionar su número de teléfono significa que usted ha optado por lo siguiente para usar el servicio GetYourRefund:'

crontab

@@ -15,3 +15,4 @@
 0 21 27 10 * bundle exec rake users:suspend_non_admins
 0 18 21 10 * bundle exec rake state_file:send_deadline_reminder_tomorrow
 0 18 22 10 * bundle exec rake state_file:send_deadline_reminder_today
+0 18 16 10 * bundle exec rake state_file:send_october_transfer_reminder

lib/tasks/state_file.rake

@@ -35,6 +35,11 @@ namespace :state_file do
     StateFile::SendMarketingEmailService.run
   end
 
+  task send_october_transfer_reminder: :environment do
+    return unless DateTime.now.year == 2025
+    StateFile::OctoberTransferReminderService.run
+  end
+
   task backfill_intake_submission_pdfs: :environment do
     batch_size = 5
     intake_types = StateFile::StateInformationService.state_intake_classes

spec/models/state_file_base_intake_spec.rb

@@ -681,6 +681,107 @@
     end
   end
 
+  describe ".selected_intakes_for_first_deadline_reminder_notification" do
+    let!(:az_intake_with_email_notifications_and_df_import) {
+      create :state_file_az_intake,
+             df_data_imported_at: 2.minutes.ago,
+             email_address: '[email protected]',
+             email_address_verified_at: 5.minutes.ago,
+             email_notification_opt_in: 1
+    }
+    let!(:az_intake_with_email_notifications_and_df_import_from_last_year) {
+      create :state_file_az_intake,
+             df_data_imported_at: 2.minutes.ago,
+             email_address: '[email protected]',
+             email_address_verified_at: 5.minutes.ago,
+             email_notification_opt_in: 1,
+             created_at: 1.year.ago
+    }
+    let!(:az_intake_with_email_notifications_without_df_import) {
+      create :state_file_az_intake,
+             df_data_imported_at: nil,
+             email_address: '[email protected]',
+             email_address_verified_at: 5.minutes.ago,
+             email_notification_opt_in: 1,
+             message_tracker: { "messages.state_file.welcome" => 2.days.ago.utc.strftime("%Y-%m-%d %H:%M:%S UTC") }
+    }
+    let!(:az_intake_with_recent_message) {
+      create :state_file_az_intake,
+             df_data_imported_at: nil,
+             email_address: '[email protected]',
+             email_address_verified_at: 5.minutes.ago,
+             email_notification_opt_in: 1,
+             message_tracker: { "messages.state_file.welcome" => DateTime.now.utc.strftime("%Y-%m-%d %H:%M:%S UTC") }
+    }
+    let!(:az_intake_with_text_notifications_and_df_import) {
+      create :state_file_az_intake,
+             df_data_imported_at: 2.minutes.ago,
+             phone_number: "+15551115511",
+             sms_notification_opt_in: 1,
+             phone_number_verified_at: 5.minutes.ago
+    }
+    let!(:az_intake_with_unverified_text_notifications_and_df_import) {
+      create :state_file_az_intake,
+             df_data_imported_at: 2.minutes.ago,
+             phone_number: "+15551115511",
+             sms_notification_opt_in: "yes",
+             email_address: '[email protected]',
+             email_address_verified_at: 5.minutes.ago,
+             email_notification_opt_in: "no"
+    }
+    let!(:az_intake_submitted) {
+      create :state_file_az_intake,
+             df_data_imported_at: 2.minutes.ago,
+             email_address: '[email protected]',
+             email_address_verified_at: 5.minutes.ago,
+             email_notification_opt_in: 1
+    }
+    let!(:efile_submission) { create :efile_submission, :for_state, data_source: az_intake_submitted }
+
+    let!(:az_intake_has_disqualifying_df_data) {
+      create :state_file_az_intake,
+             filing_status: :married_filing_separately,
+             email_address: "[email protected]",
+             email_address_verified_at: 1.hour.ago,
+             email_notification_opt_in: 1,
+             df_data_imported_at: 2.minutes.ago
+    }
+
+    let!(:az_intake_submitted_ssn_duplicate) {
+      create :state_file_az_intake,
+             email_address: "[email protected]",
+             email_address_verified_at: 1.hour.ago,
+             email_notification_opt_in: 1,
+             phone_number: nil,
+             df_data_imported_at: 2.minutes.ago,
+             hashed_ssn: "111443333"
+    }
+    let!(:az_intake_submitted_ssn_duplicate_1) {
+      create :state_file_az_intake,
+             email_address: "[email protected]",
+             email_address_verified_at: 1.hour.ago,
+             email_notification_opt_in: 1,
+             phone_number: nil,
+             df_data_imported_at: 2.minutes.ago,
+             hashed_ssn: "111443333"
+    }
+    let!(:efile_submission_for_duplicate) { create :efile_submission, :for_state, data_source: az_intake_submitted_ssn_duplicate }
+
+    before do
+      allow(Flipper).to receive(:enabled?).and_call_original
+      allow(Flipper).to receive(:enabled?).with(:prevent_duplicate_ssn_messaging).and_return(true)
+
+      allow_any_instance_of(StateFileAzIntake).to receive(:should_be_sent_reminder?).and_return(true)
+    end
+
+    it "returns only current-year intakes without df data that have no other messages within the past 24 hours and have no disqualifying/duplicate-with-submission issues" do
+      results = StateFileAzIntake.selected_intakes_for_first_deadline_reminder_notification
+
+      expect(results).to match_array([az_intake_with_email_notifications_without_df_import])
+    end
+  end
+
+
   describe "#should_be_sent_reminder?" do
     let(:message_tracker) { nil }
     let(:intake) { create :state_file_az_intake, message_tracker: message_tracker }

spec/tasks/october_transfer_reminder_spec.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+require 'rails_helper'
+
+describe 'state_file:october_transfer_reminder' do
+  before(:all) do
+    Rake.application.rake_require "tasks/state_file"
+  end
+
+  around do |example|
+    Timecop.freeze(DateTime.parse("2-12-2025")) do
+      example.run
+    end
+  end
+
+  it 'sends messages via appropriate contact method to intakes without submissions, with or without df data that is not disqualifying' do
+    az_intake_to_notify = create(:state_file_az_intake)
+    az_intake_to_not_notify = create(:state_file_az_intake)
+    nc_intake = create(:state_file_nc_intake)
+    allow(StateFileAzIntake).to receive(:selected_intakes_for_first_deadline_reminder_notification).and_return([az_intake_to_notify])
+    allow(StateFileNcIntake).to receive(:selected_intakes_for_first_deadline_reminder_notification).and_return([nc_intake])
+    messaging_service = spy('StateFile::MessagingService')
+    allow(StateFile::MessagingService).to receive(:new).and_return(messaging_service)
+
+    Rake::Task['state_file:send_october_transfer_reminder'].execute
+
+    expect(StateFile::MessagingService).to have_received(:new).exactly(2).times
+    expect(StateFile::MessagingService).to have_received(:new).with(message: StateFile::AutomatedMessage::OctoberTransferReminder, intake: az_intake_to_notify)
+    expect(StateFile::MessagingService).to have_received(:new).with(message: StateFile::AutomatedMessage::OctoberTransferReminder, intake: nc_intake)
+    expect(StateFile::MessagingService).to_not have_received(:new).with(message: StateFile::AutomatedMessage::OctoberTransferReminder, intake: az_intake_to_not_notify)
+  end
+end