Merge branch 'main' into WRSAT-505

Author: cram-cfa

lib/pdf_filler/packet_pdf.rb

@@ -63,9 +63,18 @@ def hash_for_generated_pdf
     def filled_pdf_path
       source_pdf_path = "app/assets/pdfs/nc_packet--no-income.pdf"
       template_doc = HexaPDF::Document.open(source_pdf_path)
+
+      unless template_doc
+        Rails.logger.error "Unable to generate PDF from #{source_pdf_path}"
+        return
+      end
+
       hash_for_fillable_pdf.each do |field_name, field_value|
         template_doc.acro_form.field_by_name(field_name.to_s).field_value = field_value
       end
+
+      template_doc.acro_form.flatten
+
       pdf_tempfile = Tempfile.new(["packet", ".pdf"], "tmp/")
       template_doc.write(pdf_tempfile)
       pdf_tempfile.path

spec/lib/pdf_filler/packet_pdf_spec.rb

@@ -181,7 +181,7 @@
   end
 
   describe "#filled_pdf_path" do
-    it "fills the PDF without errors" do
+    it "fills and flattens the PDF (no editable fields remain)" do
       screener.assign_attributes(
         phone_number: "9195550123",
         is_american_indian: "yes",
@@ -214,7 +214,19 @@
         preventing_work_write_in: "Chronic back pain"
       )
 
-      expect { packet_pdf.filled_pdf_path }.not_to raise_error
+      path = nil
+
+      expect {
+        path = packet_pdf.filled_pdf_path
+      }.not_to raise_error
+
+      doc = HexaPDF::Document.open(path)
+
+      # Assert it's flattened (read-only)
+      form = doc.acro_form
+      expect(form).to be_nil.or have_attributes(fields: be_empty)
+    ensure
+      File.delete(path) if path && File.exist?(path)
     end
   end
 end