Fix #60: Only do purging every once in a while

Author: codeling

bfstop.php

@@ -320,7 +320,19 @@ public function onAfterInitialise()
 		{
 			return;
 		}
-		$this->mydb->purgeOldEntries((int)$this->params->get('deleteOld', 0));
+		$purgeAge = (int)$this->params->get('deleteOld', 0);
+		if ($purgeAge > 0)
+		{
+			$purgeInterval = 86400; // = 24*60*60 => one day
+			$lastPurge = $this->params->get('lastPurge', 0);
+			$now = time();
+			if ($now > ($lastPurge + $purgeInterval))
+			{
+				$this->mydb->purgeOldEntries($purgeAge);
+				$this->params->set('lastPurge', $now);
+				$this->mydb->saveParams($this->params);
+			}
+		}
 		$ipaddress = $this->getIPAddr();
 		if ($this->mydb->isIPWhiteListed($ipaddress))
 		{

helpers/db.php

@@ -278,15 +278,12 @@ public function successfulLogin($info)
 		$this->setFailedLoginHandled($info, true);
 	}
 
-	public function purgeOldEntries($olderThanWeeks)
+	public function purgeOldEntries($purgeAgeWeeks)
 	{
-		if ($olderThanWeeks == 0)
-		{
-			return;
-		}
+		$this->logger->log("Purging entries older than $purgeAgeWeeks weeks", JLog::INFO);
 		$deleteDate = 'DATE_SUB('.
 			' NOW(), INTERVAL '.
-			$this->db->quote($olderThanWeeks).
+			$this->db->quote($purgeAgeWeeks).
 			' WEEK)';
 		$sql = 'DELETE FROM #__bfstop_failedlogin WHERE logtime < '.$deleteDate;
 		$this->db->setQuery($sql);
@@ -310,4 +307,14 @@ public function purgeOldEntries($olderThanWeeks)
 		$this->db->query();
 		$this->myCheckDBError();
 	}
+
+	public function saveParams($params)
+	{
+		$query = $this->db->getQuery(true);
+		$query->update('#__extensions AS a');
+		$query->set('a.params = '. $this->db->quote((string)$params) );
+		$query->where('a.element = "bfstop"');
+		$this->db->setQuery($query);
+		$this->db->query();
+	}
 }

helpers/notify.php

@@ -25,7 +25,7 @@ function __construct($logger, $db, $emailAddress, $userID, $userGroup, $groupNot
 		}
 		if (count($this->notifyAddresses) == 0)
 		{
-			$this->logger->log('No notification address specified!', JLog::INFO);
+			$this->logger->log('No notification address specified!', JLog::DEBUG);
 		}
 	}