Fix for sloppy empty IP address check

codeling · codeling · commit f37a7bea209c · 2017-01-25T00:53:16.000+01:00
diff --git a/bfstop.php b/bfstop.php
@@ -294,9 +294,9 @@ public function onUserLoginFailure($user, $options=null)
 			return;
 		}
 		$ipAddress = $this->getIPAddr();
-		if (empty($ipaddress) || $ipaddress === '')
+		if (empty($ipAddress) || $ipAddress === '')
 		{
-			$this->logger->log('Empty ip address!', JLog::ERROR);
+			$this->logger->log('Empty IP address!', JLog::ERROR);
 			return;
 		}
 		if ($this->mydb->isIPWhiteListed($ipAddress))

Original file line number	Diff line number	Diff line change
`@@ -294,9 +294,9 @@ public function onUserLoginFailure($user, $options=null)`
`294`	`294`	`return;`
`295`	`295`	`}`
`296`	`296`	`$ipAddress = $this->getIPAddr();`
`297`		`- if (empty($ipaddress) \|\| $ipaddress === '')`
	`297`	`+ if (empty($ipAddress) \|\| $ipAddress === '')`
`298`	`298`	`{`
`299`		`- $this->logger->log('Empty ip address!', JLog::ERROR);`
	`299`	`+ $this->logger->log('Empty IP address!', JLog::ERROR);`
`300`	`300`	`return;`
`301`	`301`	`}`
`302`	`302`	`if ($this->mydb->isIPWhiteListed($ipAddress))`