Commit 22a0eb2
ci(js-port): bump screenshot timeout to 1200s + skip SheetSlideUpAnimation
Two related fixes on top of dc686dd:
1. .github/workflows/scripts-javascript.yml: raise the per-suite
``CN1_JS_TIMEOUT_SECONDS`` budget from 720s to 1200s. With the
``jsChunkDrop`` block removed and 58 previously-dropped tests
now actually rendering full PNG streams, the suite walks at
~10s/test on shared GHA runners (vs. ~milliseconds when the
chunks were silently truncated). 720s was occasionally too
tight to reach ``CN1SS:SUITE:FINISHED`` -- the run on dc686dd
timed out at SheetSlideUpAnimationScreenshotTest (test 66/73)
while a run on 2fd58aa finished comparison at minute 14. 1200s
absorbs the per-test variance.
2. Ports/JavaScriptPort/src/main/webapp/port.js: park
SheetSlideUpAnimationScreenshotTest under
``chartDocumentStaleness`` alongside ToastBarTopPositionScreenshotTest
and the chart tail. Same canvas-accumulation cascade -- by the
time these tests run, ``Document.createElement(canvas)`` returns
a null host receiver and the screenshot phase never reaches
SCREENSHOT_DONE. The exact test that bites varies between runs
depending on canvas pressure, but those three (plus the six
later charts) consistently end up on the wrong side of the
threshold. Also remove its golden since the test will no longer
emit.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent dc686dd commit 22a0eb2
3 files changed
Lines changed: 25 additions & 23 deletions
File tree
- .github/workflows
- Ports/JavaScriptPort/src/main/webapp
- scripts/javascript/screenshots
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
71 | 70 | | |
72 | 71 | | |
73 | 72 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3133 | 3133 | | |
3134 | 3134 | | |
3135 | 3135 | | |
3136 | | - | |
3137 | | - | |
3138 | | - | |
3139 | | - | |
3140 | | - | |
3141 | | - | |
3142 | | - | |
| 3136 | + | |
| 3137 | + | |
| 3138 | + | |
| 3139 | + | |
| 3140 | + | |
| 3141 | + | |
| 3142 | + | |
| 3143 | + | |
| 3144 | + | |
3143 | 3145 | | |
3144 | 3146 | | |
3145 | 3147 | | |
| |||
3179 | 3181 | | |
3180 | 3182 | | |
3181 | 3183 | | |
3182 | | - | |
| 3184 | + | |
| 3185 | + | |
3183 | 3186 | | |
3184 | 3187 | | |
3185 | 3188 | | |
| |||
Binary file not shown.
0 commit comments