Skip to content

Commit 2a4fe39

Browse files
shai-almogclaude
andcommitted
Revert -Wno-error: the JavaAPI setDaemon fix was the real fix
Adding Thread.setDaemon to the JavaAPI makes the translator emit the wrapper AND the cross-class include, so there are no implicit declarations left to tolerate (verified: zero in the demo build). Drop the -Wno-error tolerance so the zig build stays strict and would catch a real future regression. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent b0766aa commit 2a4fe39

2 files changed

Lines changed: 0 additions & 10 deletions

File tree

.github/workflows/linux-build-run.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -192,12 +192,7 @@ jobs:
192192
sudo tee /usr/local/bin/cn1-zig-cc >/dev/null << 'WRAP'
193193
#!/bin/sh
194194
ARCH=$(uname -m)
195-
# -Wno-error=implicit-function-declaration: the translator occasionally
196-
# omits a cross-class #include for a void runtime wrapper the generated C
197-
# calls (harmless under gcc; clang/zig promotes it to an error). The
198-
# wrapper is still defined, so it links and runs -- match gcc here.
199195
exec zig cc -target ${ARCH}-linux-gnu.2.28 -D_DEFAULT_SOURCE -Wno-macro-redefined \
200-
-Wno-error=implicit-function-declaration \
201196
-L/usr/lib/${ARCH}-linux-gnu -L/lib/${ARCH}-linux-gnu "$@"
202197
WRAP
203198
sudo chmod +x /usr/local/bin/cn1-zig-cc

maven/codenameone-maven-plugin/src/main/java/com/codename1/builders/LinuxNativeBuilder.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -402,11 +402,6 @@ private File writeZigCcWrapper(String arch, boolean musl) {
402402
// system paths). The arch dir is resolved at run time so the same
403403
// wrapper works native or cross.
404404
sh.append(" -D_DEFAULT_SOURCE -Wno-macro-redefined");
405-
// The translator occasionally omits a cross-class include for a void
406-
// runtime wrapper the generated C calls (a no-op under gcc; clang/zig
407-
// makes it an error). It is still defined, so match gcc and keep it a
408-
// warning rather than failing the build.
409-
sh.append(" -Wno-error=implicit-function-declaration");
410405
sh.append(" -L/usr/lib/$(uname -m)-linux-gnu -L/usr/lib64 -L/lib/$(uname -m)-linux-gnu");
411406
}
412407
sh.append(" \"$@\"\n");

0 commit comments

Comments
 (0)