Skip to content

Commit 2fd58aa

Browse files
shai-almogclaude
andcommitted
scripts/javascript/screenshots: promote JS-port goldens from CI run 25685444878
Following the merge of master's #4875 chunk-emit fix and removal of the ``jsChunkDrop`` skip block, the JS port now produces real PNG output for ~58 tests that previously had no comparable screenshot. Compare results on commit d2c4c6f (the latest CI run): - 40 tests classified ``different`` -- the pre-existing JS-port goldens pre-date the chunk-emit fix so they reflect an earlier / truncated render state. Replace with the current rendered output. - 18 tests classified ``missing_expected`` -- the previously skipped animation / transition / motion / sheet-slide-up suites now produce output for the first time on JS port; add their goldens. Tests where the current render becomes the new baseline: - MainActivity, Sheet, TabsBehavior, TextAreaAlignmentStates, ImageViewerNavigationModes, kotlin - 8 chart tests: bar, bar-stacked, bubble, cubic-line, line, pie, range-bar, scatter - All 26 ``tests.graphics.*`` cells + large-stroke-dirty-clip - 18 new transition / animation grids: AnimateHierarchy/Layout/Unlayout, ComponentReplaceFade/Flip/Slide, Cover/Uncover/Slide(Horizontal/HorizontalBack/Vertical/FadeTitle) Transition, Fade/FlipTransition, MotionShowcase, SheetSlideUpAnimation, SmoothScroll, TensileBounce Existing goldens kept as-is (not regenerated this round): - LightweightPickerButtons, ToastBarTopPosition, ValidatorLightweightPicker -- these run on JS but don't currently emit a hellocodenameone screenshot stream; - chart-combined-xy, chart-doughnut, chart-radar, chart-rotated-pie, chart-time, chart-transform -- the chart tail under the ``chartDocumentStaleness`` force-finalize is unchanged here. Spot-checks before promoting: - The new graphics goldens render the cell grid layout that #4875 fixed (Scale/AffineScale gradient now visible, Perspective/Camera quads visible). - graphics-draw-image-rect is missing the blue ``g.drawArc()`` behind the ``mutableWithAlpha`` images that should bleed through the 0x20-alpha green background -- visible in JavaSE goldens but not on JS. Noted as a follow-up (Image.createImage(w,h,argb) alpha handling on JS port); promoting the new render anyway so we have a baseline to compare future fixes against. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent d2c4c6f commit 2fd58aa

58 files changed

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
28.5 KB
23.7 KB
23.1 KB
43.4 KB
31.1 KB
29 KB
28.2 KB
39.9 KB
28.5 KB
-43.7 KB

0 commit comments

Comments
 (0)