test(pkg/integration/replication): Make tests independent

Instead of creating a single cluster shared across the test suite,
create independent cluster for each suite.

Signed-off-by: Bartłomiej Święcki <[email protected]>

Author: Bartłomiej Święcki

pkg/integration/replication/suite.go

@@ -307,8 +307,8 @@ func (suite *baseReplicationTestSuite) SetupCluster(syncReplicas, syncAcks, asyn
 	wg.Wait()
 }
 
-// SetupSuite initializes the suite
-func (suite *baseReplicationTestSuite) SetupSuite() {
+// SetupTest initializes the suite
+func (suite *baseReplicationTestSuite) SetupTest() {
 	suite.mu.Lock()
 	defer suite.mu.Unlock()
 
@@ -318,7 +318,7 @@ func (suite *baseReplicationTestSuite) SetupSuite() {
 }
 
 // this function executes after all tests executed
-func (suite *baseReplicationTestSuite) TearDownSuite() {
+func (suite *baseReplicationTestSuite) TearDownTest() {
 	suite.mu.Lock()
 	defer suite.mu.Unlock()
 
@@ -328,10 +328,12 @@ func (suite *baseReplicationTestSuite) TearDownSuite() {
 			srv.Shutdown(suite.T())
 		}
 	}
+	suite.followers = []TestServer{}
 
 	// stop master
 	if suite.master != nil {
 		suite.master.Shutdown(suite.T())
 		suite.master = nil
 	}
+	suite.master = nil
 }

pkg/integration/replication/synchronous_replication_test.go

@@ -22,8 +22,8 @@ func TestSyncTestSuite(t *testing.T) {
 }
 
 // this function executes before the test suite begins execution
-func (suite *SyncTestSuite) SetupSuite() {
-	suite.baseReplicationTestSuite.SetupSuite()
+func (suite *SyncTestSuite) SetupTest() {
+	suite.baseReplicationTestSuite.SetupTest()
 	suite.SetupCluster(2, 2, 0)
 }
 
@@ -166,8 +166,8 @@ func TestSyncTestMinimumFollowersSuite(t *testing.T) {
 }
 
 // this function executes before the test suite begins execution
-func (suite *SyncTestMinimumFollowersSuite) SetupSuite() {
-	suite.baseReplicationTestSuite.SetupSuite()
+func (suite *SyncTestMinimumFollowersSuite) SetupTest() {
+	suite.baseReplicationTestSuite.SetupTest()
 	suite.SetupCluster(4, 2, 0)
 }
 
@@ -263,8 +263,8 @@ func TestSyncTestRecoverySpeedSuite(t *testing.T) {
 	suite.Run(t, &SyncTestRecoverySpeedSuite{})
 }
 
-func (suite *SyncTestRecoverySpeedSuite) SetupSuite() {
-	suite.baseReplicationTestSuite.SetupSuite()
+func (suite *SyncTestRecoverySpeedSuite) SetupTest() {
+	suite.baseReplicationTestSuite.SetupTest()
 	suite.SetupCluster(2, 1, 0)
 }
 
@@ -394,8 +394,8 @@ func TestSyncTestWithAsyncFollowersSuite(t *testing.T) {
 	suite.Run(t, &SyncTestWithAsyncFollowersSuite{})
 }
 
-func (suite *SyncTestWithAsyncFollowersSuite) SetupSuite() {
-	suite.baseReplicationTestSuite.SetupSuite()
+func (suite *SyncTestWithAsyncFollowersSuite) SetupTest() {
+	suite.baseReplicationTestSuite.SetupTest()
 	suite.SetupCluster(2, 1, 1)
 }
 
@@ -483,8 +483,8 @@ func TestSyncTestChangingMasterSuite(t *testing.T) {
 	suite.Run(t, &SyncTestChangingMasterSuite{})
 }
 
-func (suite *SyncTestChangingMasterSuite) SetupSuite() {
-	suite.baseReplicationTestSuite.SetupSuite()
+func (suite *SyncTestChangingMasterSuite) SetupTest() {
+	suite.baseReplicationTestSuite.SetupTest()
 	suite.SetupCluster(2, 1, 0)
 }