Revert "feat(cmd): process launcher check if are present another ista… (#475)

* Revert "feat(cmd): process launcher check if are present another istances. fixes #168"

This reverts commit 8f58798.

* chore: update go mod files

Author: jeroiraz

ACKNOWLEDGEMENTS.md

@@ -44,4 +44,4 @@ immudb uses the following amazing open source projects. Copyright by their respe
 | [gotenv](https://github.com/subosito/gotenv)                 | [MIT](https://github.com/subosito/gotenv/blob/master/LICENSE) |
 | [poly1305](https://github.com/aead/poly1305)                 | [MIT](https://github.com/aead/poly1305/blob/master/LICENSE)  |
 | [Go CORS handler](https://github.com/rs/cors)                | [MIT](https://github.com/rs/cors/blob/master/LICENSE)        |
-| [Process List Library for Go](https://github.com/mitchellh/go-ps/) | [MIT](https://github.com/mitchellh/go-ps/blob/master/LICENSE.md)        |
+

cmd/helper/detached.go

@@ -18,12 +18,9 @@ package helper
 
 import (
 	"fmt"
-	"github.com/codenotary/immudb/cmd/version"
-	"github.com/mitchellh/go-ps"
 	"os"
 	"os/exec"
 	"path/filepath"
-	"strings"
 	"time"
 )
 
@@ -45,7 +42,6 @@ func (e execs) Command(name string, arg ...string) *exec.Cmd {
 
 type Plauncher interface {
 	Detached() error
-	Process(processName string) (found bool, p ps.Process, err error)
 }
 
 type plauncher struct {
@@ -66,10 +62,6 @@ func (pl plauncher) Detached() error {
 		return err
 	}
 
-	if exists, p, _ := pl.Process(version.App); exists {
-		return fmt.Errorf("%s is already running. Pid %d", version.App, p.Pid())
-	}
-
 	for i, k := range os.Args {
 		if k != "--"+DetachedFlag && k != "-"+DetachedShortFlag && i != 0 {
 			args = append(args, k)
@@ -89,17 +81,3 @@ func (pl plauncher) Detached() error {
 		Green, filepath.Base(executable), Blue, cmd.Process.Pid, Reset)
 	return nil
 }
-
-//Process find a process with the given name
-func (pl plauncher) Process(processName string) (found bool, p ps.Process, err error) {
-	ps, err := ps.Processes()
-	if err != nil {
-		return false, p, err
-	}
-	for _, p1 := range ps {
-		if strings.Contains(p1.Executable(), processName) {
-			return true, p1, nil
-		}
-	}
-	return false, nil, nil
-}

cmd/helper/detached_test.go

@@ -18,7 +18,6 @@ package helper
 
 import (
 	"bytes"
-	"github.com/codenotary/immudb/cmd/version"
 	"github.com/stretchr/testify/assert"
 	"os/exec"
 	"strings"
@@ -36,8 +35,7 @@ func (e execsmock) Command(name string, arg ...string) *exec.Cmd {
 }
 
 func TestDetached(t *testing.T) {
-	version.App = "notexists"
-	pl := plauncher{e: execsmock{}}
+	pl := plauncher{execsmock{}}
 	err := pl.Detached()
 	assert.Nil(t, err)
 }

cmd/immudb/command/cmd.go

@@ -106,8 +106,6 @@ func (cl *Commandline) Immudb(immudbServer server.ImmuServerIf) func(*cobra.Comm
 		if options.Detached {
 			if err := cl.P.Detached(); err == nil {
 				return nil
-			} else {
-				c.QuitToStdErr(err)
 			}
 		}
 

cmd/immudb/command/cmd_test.go

@@ -18,7 +18,6 @@ package immudb
 
 import (
 	"bytes"
-	"github.com/mitchellh/go-ps"
 	"os"
 	"testing"
 
@@ -210,7 +209,3 @@ type plauncherMock struct{}
 func (pl plauncherMock) Detached() error {
 	return nil
 }
-
-func (pl plauncherMock) Process(processName string) (found bool, p ps.Process, err error) {
-	return false, nil, nil
-}

go.mod

@@ -16,7 +16,6 @@ require (
 	github.com/jaswdr/faker v1.0.2
 	github.com/mattn/go-runewidth v0.0.9 // indirect
 	github.com/mitchellh/go-homedir v1.1.0
-	github.com/mitchellh/go-ps v1.0.0
 	github.com/mitchellh/go-wordwrap v1.0.0 // indirect
 	github.com/nsf/termbox-go v0.0.0-20200418040025-38ba6e5628f1 // indirect
 	github.com/o1egl/paseto v1.0.0

go.sum

@@ -157,8 +157,6 @@ github.com/matttproud/golang_protobuf_extensions v1.0.1 h1:4hp9jkHxhMHkqkrB3Ix0j
 github.com/matttproud/golang_protobuf_extensions v1.0.1/go.mod h1:D8He9yQNgCq6Z5Ld7szi9bcBfOoFv/3dc6xSMkL2PC0=
 github.com/mitchellh/go-homedir v1.1.0 h1:lukF9ziXFxDFPkA1vsr5zpc1XuPDn/wFntq5mG+4E0Y=
 github.com/mitchellh/go-homedir v1.1.0/go.mod h1:SfyaCUpYCn1Vlf4IUYiD9fPX4A5wJrkLzIz1N1q0pr0=
-github.com/mitchellh/go-ps v1.0.0 h1:i6ampVEEF4wQFF+bkYfwYgY+F/uYJDktmvLPf7qIgjc=
-github.com/mitchellh/go-ps v1.0.0/go.mod h1:J4lOc8z8yJs6vUwklHw2XEIiT4z4C40KtWVN3nvg8Pg=
 github.com/mitchellh/go-wordwrap v0.0.0-20150314170334-ad45545899c7 h1:DpOJ2HYzCv8LZP15IdmG+YdwD2luVPHITV96TkirNBM=
 github.com/mitchellh/go-wordwrap v0.0.0-20150314170334-ad45545899c7/go.mod h1:ZXFpozHsX6DPmq2I0TCekCxypsnAUbP2oI0UX1GXzOo=
 github.com/mitchellh/go-wordwrap v1.0.0 h1:6GlHJ/LTGMrIJbwgdqdl2eEH8o+Exx/0m8ir9Gns0u4=