Skip to content

Support 'tag' template helper within renderer #224

Open
@Flauschbaellchen

Description

@Flauschbaellchen

If using a custom renderer it is not possible to use the tag helper which is a shorter variant for content_tag and is preferred by Rails style guides.
The SimpleNavigation::Renderer::Base does not delegate tag to the template adapter.

Documentation:
rails/rails#25195
https://docs.rubocop.org/rubocop-rails/cops_rails.html#railscontenttag

It would be great to see this implemented.
Currently I've excluded any renderers from Rubocop's auto-correction feature.

Activity

andi

andi commented on Jun 23, 2020

@andi
Collaborator

It would be great if you could contribute with a PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

      Participants

      @andi@Flauschbaellchen

      Issue actions

        Support 'tag' template helper within renderer · Issue #224 · codeplant/simple-navigation