Skip to content

Commit 3568453

Browse files
committed
MR feedback and minor fixes
1 parent 4542feb commit 3568453

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,5 +63,5 @@ from this registry in the future.
6363
| CP020 | [Interop Task](interop_task/interop_task.md) | SYCL 1.2.1 | 16 January 2019 | 16 January 2019 | _Available since CE 1.0.5_ |
6464
| CP021 | [Default-Constructed Buffers](default-constructed-buffers/default-constructed-buffers.md) | SYCL 1.2.1 | 27 August 2019 | 5 September 2019 | _Draft_ |
6565
| CP022 | [Host Task with Interop capabilities](host_task/host_task.md) | SYCL 1.2.1 | 16 January 2019 | 20 January 2020 | _Final Draft_ |
66-
| CP023 | [Accessor aliases](accessor-alias/index.md) | SYCL Next (after 1.2.1) | 22 September 2019 | 9 March 2020 | _Work in Progress_ |
66+
| CP023 | [Accessor aliases](accessor-alias/index.md) | SYCL Next (after 1.2.1) | 22 September 2019 | 31 March 2020 | _Work in Progress_ |
6767
| CP026 | [Generalized Error Handling For SYCL](error-handling/sycl-error-handling.md) | SYCL Next | 10 March 2020 | 10 March 2020 | _Under Review_ |

accessor-alias/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
| Name | Accessor aliases |
66
| Date of Creation | 22 September 2019 |
77
| Revision | 0.2 |
8-
| Latest Update | 9 March 2020 |
8+
| Latest Update | 31 March 2020 |
99
| Target | SYCL Next (after 1.2.1) |
1010
| Current Status | _Work in Progress_ |
1111
| Reply-to | Peter Žužek <[email protected]> |

accessor-alias/sycl-2.2/index.md

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -286,9 +286,15 @@ q.submit([&](handler& cgh){
286286
287287
// 4
288288
// Allow all combinations
289-
const_int_read_write(accIntConst)
290-
int_read(accInt)
291-
const_int_read(accInt)
289+
const_int_read_write(accIntConst);
290+
const_int_read_write(accessor<int, 1, access::mode::read>{});
291+
const_int_read_write(accessor<const int, 1, access::mode::read>{});
292+
int_read(accInt);
293+
int_read(accessor<const int>{});
294+
int_read(accessor<const int, 1, access::mode::read>{});
295+
const_int_read(accInt);
296+
const_int_read(accessor<const int>{});
297+
const_int_read(accessor<const int, 1, access::mode::read>{});
292298
293299
...
294300
});
@@ -470,6 +476,7 @@ it wouldn't work with `access::target::constant_buffer`
470476
or `access::target::host_buffer`
471477
since those rely on alias templates
472478
`constant_buffer_accessor` and `host_accessor`, respectively.
479+
This also affects the `local_accessor` alias already in SYCL 1.2.1.
473480
474481
An option for solving this pre-C++20 would be
475482
to define `constant_buffer_accessor` and `host_accessor` as new types

0 commit comments

Comments
 (0)