Skip to content

Commit 09e8f1f

Browse files
committed
test: improve expressiveness with sequences access to results
1 parent 7c5d3f4 commit 09e8f1f

5 files changed

Lines changed: 6 additions & 5 deletions

File tree

docs/changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ category: Administration
1313

1414
* feat: ensure compatibility with Jira 11.3.1
1515
* test: access static member directly
16+
* test: improve expressiveness with sequences access to results
1617

1718
### [25.12.1] - 2025-12-12
1819

src/test/java/de/codescape/jira/plugins/scrumpoker/jql/ActiveScrumPokerSessionsJqlFunctionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public void jqlFunctionReturnsIdValueOfIssueKeyForActiveSession() {
100100
new FunctionOperand(ActiveScrumPokerSessionsJqlFunction.FUNCTION_NAME),
101101
mock(TerminalClause.class));
102102
assertThat(activeScrumPokerSessions.size(), is(1));
103-
assertThat(activeScrumPokerSessions.get(0).getLongValue(), is(equalTo(42L)));
103+
assertThat(activeScrumPokerSessions.getFirst().getLongValue(), is(equalTo(42L)));
104104
}
105105

106106
/* tests for getMinimumNumberOfExpectedArguments() */

src/test/java/de/codescape/jira/plugins/scrumpoker/rest/mapper/SessionReferenceMapperTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public void shouldExcludeIssuesWhereIssueCannotBeFound() {
5454
ReferenceListEntity referenceListEntity = sessionReferenceMapper.build(scrumPokerSessions, "5");
5555
assertThat(referenceListEntity.isResults(), is(true));
5656
assertThat(referenceListEntity.getReferences().size(), is(1));
57-
assertThat(referenceListEntity.getReferences().get(0).getIssueKey(), equalTo("ISSUE-5"));
57+
assertThat(referenceListEntity.getReferences().getFirst().getIssueKey(), equalTo("ISSUE-5"));
5858
}
5959

6060
private List<ScrumPokerSession> scrumPokerSessionsWithKeys(String... keys) {

src/test/java/de/codescape/jira/plugins/scrumpoker/service/EstimateFieldServiceImplTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ public void supportedCustomFieldsOnlyReturnsFieldsOfSupportedType() {
362362
List<CustomField> customFields = estimateFieldService.supportedCustomFields();
363363

364364
assertThat(customFields.size(), is(equalTo(1)));
365-
assertThat(customFields.get(0).getCustomFieldType().getKey(), is(equalTo(CUSTOM_FIELD_TYPE_NUMBER)));
365+
assertThat(customFields.getFirst().getCustomFieldType().getKey(), is(equalTo(CUSTOM_FIELD_TYPE_NUMBER)));
366366
}
367367

368368
/* supporting methods */

src/test/java/de/codescape/jira/plugins/scrumpoker/service/ScrumPokerSessionServiceImplTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ public void shouldIncludeNewSessionInRecentSessions() {
175175
List<ScrumPokerSession> recent = scrumPokerSessionService.recent();
176176
// then it should be included
177177
assertThat(recent.size(), equalTo(1));
178-
assertThat(recent.get(0).getIssueKey(), is(equalTo("ISSUE-1")));
178+
assertThat(recent.getFirst().getIssueKey(), is(equalTo("ISSUE-1")));
179179
}
180180

181181
@Test
@@ -191,7 +191,7 @@ public void shouldOnlyIncludeSessionsWithinTheTimeoutInRecentSessions() {
191191
List<ScrumPokerSession> recent = scrumPokerSessionService.recent();
192192
// then only the new one should be included
193193
assertThat(recent.size(), is(equalTo(1)));
194-
assertThat(recent.get(0).getIssueKey(), is(equalTo("ISSUE-2")));
194+
assertThat(recent.getFirst().getIssueKey(), is(equalTo("ISSUE-2")));
195195
}
196196

197197
/* tests for cancel() */

0 commit comments

Comments
 (0)