Skip to content

Improve documents on reviewing and approving a kata #347

Open
@XRFXLP

Description

The article under concern: https://docs.codewars.com/curation/kata and kata approval section

Assumption: The quality of katas depends quite significantly on the approval process, so the necessary norms and standards should be clear and precise.


The current state of the document on this topic is vague, imprecise, and redundant which makes it easy to miss the important points. There is no sharp distinction on roles of approvers and reviewers (which should be), an approver can be a reviewer but the responsibility in being an approver is more than a reviewer.

(A reviewer (if it is defined by one of who solves a kata) can choose to not check anything and drop "Very satisfied", which is not a big problem)


At least these points should be in documentations and the approver should take care of them:

  1. Check for the duplicate: one should not assume that the kata is not duplicate just because no one has raised an issue on it, one must ensure and ask in relevant discord chatroom for the same.
  2. Check the discourse for unfixed issue/potential issues: It is not uncommon that authors in the rush of making their kata out of beta resolve issues because they think it is not an issue, or sometimes some users resolve issues based on downvotes, sometimes there are legit doubts about duplicacy, but the reviewer is not sure about it and it is often neglected by approvers [1] [2]

More generally, if kata is "Awaiting Approval state" that does not mean that the job of the approver is just to approve the kata without reviewing it responsibly.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions