refactor(billing): remove unused index initialization logic from promo codes and usages factories

Author: Dobrunia

migrations/20260615140000-add-promo-code-indexes.js

@@ -0,0 +1,29 @@
+/**
+ * @file Migration to add indexes for promoCodes and promoCodeUsages collections
+ */
+module.exports = {
+  async up(db) {
+    const promoCodes = db.collection('promoCodes');
+    const promoCodeUsages = db.collection('promoCodeUsages');
+
+    await promoCodes.createIndex({ value: 1 }, { unique: true });
+
+    await promoCodeUsages.createIndex({ promoCodeId: 1 });
+    await promoCodeUsages.createIndex({ promoCodeId: 1, userId: 1 }, { unique: true });
+    await promoCodeUsages.createIndex({ promoCodeId: 1, workspaceId: 1 }, { unique: true });
+    await promoCodeUsages.createIndex({ workspaceId: 1 });
+    await promoCodeUsages.createIndex({ userId: 1 });
+  },
+
+  async down(db) {
+    const promoCodes = db.collection('promoCodes');
+    const promoCodeUsages = db.collection('promoCodeUsages');
+
+    await promoCodes.dropIndex({ value: 1 });
+    await promoCodeUsages.dropIndex({ promoCodeId: 1 });
+    await promoCodeUsages.dropIndex({ promoCodeId: 1, userId: 1 });
+    await promoCodeUsages.dropIndex({ promoCodeId: 1, workspaceId: 1 });
+    await promoCodeUsages.dropIndex({ workspaceId: 1 });
+    await promoCodeUsages.dropIndex({ userId: 1 });
+  },
+};

src/models/promoCodeUsagesFactory.ts

@@ -12,11 +12,6 @@ export default class PromoCodeUsagesFactory extends AbstractModelFactory<PromoCo
    */
   protected collection: Collection<PromoCodeUsageDBScheme>;
 
-  /**
-   * Index creation promise.
-   */
-  private indexesPromise?: Promise<void>;
-
   /**
    * Creates promo code usages factory instance.
    *
@@ -33,8 +28,6 @@ export default class PromoCodeUsagesFactory extends AbstractModelFactory<PromoCo
    * @param promoCodeId - promo code id
    */
   public async countByPromoCodeId(promoCodeId: ObjectId): Promise<number> {
-    await this.ensureIndexesOnce();
-
     return this.collection.countDocuments({ promoCodeId });
   }
 
@@ -45,8 +38,6 @@ export default class PromoCodeUsagesFactory extends AbstractModelFactory<PromoCo
    * @param userId - user id
    */
   public async findByPromoCodeAndUser(promoCodeId: ObjectId, userId: string): Promise<PromoCodeUsageModel | null> {
-    await this.ensureIndexesOnce();
-
     const usage = await this.collection.findOne({
       promoCodeId,
       userId,
@@ -66,8 +57,6 @@ export default class PromoCodeUsagesFactory extends AbstractModelFactory<PromoCo
    * @param workspaceId - workspace id
    */
   public async findByPromoCodeAndWorkspace(promoCodeId: ObjectId, workspaceId: ObjectId): Promise<PromoCodeUsageModel | null> {
-    await this.ensureIndexesOnce();
-
     const usage = await this.collection.findOne({
       promoCodeId,
       workspaceId,
@@ -86,8 +75,6 @@ export default class PromoCodeUsagesFactory extends AbstractModelFactory<PromoCo
    * @param usageData - promo code usage data
    */
   public async create(usageData: Omit<PromoCodeUsageDBScheme, '_id'>): Promise<PromoCodeUsageModel> {
-    await this.ensureIndexesOnce();
-
     const usage = {
       _id: new ObjectId(),
       ...usageData,
@@ -110,30 +97,4 @@ export default class PromoCodeUsagesFactory extends AbstractModelFactory<PromoCo
       _id: usageId,
     });
   }
-
-  /**
-   * Ensures promo usage indexes exist before queries.
-   *
-   * MongoDB createIndex is idempotent: after API restart it reuses an existing index
-   * with the same keys/options and does not throw if the index is already present.
-   */
-  private async ensureIndexesOnce(): Promise<void> {
-    if (!this.indexesPromise) {
-      this.indexesPromise = Promise.all([
-        this.collection.createIndex({ promoCodeId: 1 }),
-        this.collection.createIndex({
-          promoCodeId: 1,
-          userId: 1,
-        }, { unique: true }),
-        this.collection.createIndex({
-          promoCodeId: 1,
-          workspaceId: 1,
-        }, { unique: true }),
-        this.collection.createIndex({ workspaceId: 1 }),
-        this.collection.createIndex({ userId: 1 }),
-      ]).then(() => undefined);
-    }
-
-    await this.indexesPromise;
-  }
 }

src/models/promoCodesFactory.ts

@@ -12,11 +12,6 @@ export default class PromoCodesFactory extends AbstractModelFactory<PromoCodeDBS
    */
   protected collection: Collection<PromoCodeDBScheme>;
 
-  /**
-   * Index creation promise.
-   */
-  private indexesPromise?: Promise<void>;
-
   /**
    * Creates promo codes factory instance.
    *
@@ -33,22 +28,6 @@ export default class PromoCodesFactory extends AbstractModelFactory<PromoCodeDBS
    * @param value - normalized promo code value
    */
   public async findByValue(value: string): Promise<PromoCodeModel | null> {
-    await this.ensureIndexesOnce();
-
     return this.findOne({ value });
   }
-
-  /**
-   * Ensures promo code indexes exist before queries.
-   *
-   * MongoDB createIndex is idempotent: after API restart it reuses an existing index
-   * with the same keys/options and does not throw if the index is already present.
-   */
-  private async ensureIndexesOnce(): Promise<void> {
-    if (!this.indexesPromise) {
-      this.indexesPromise = this.collection.createIndex({ value: 1 }, { unique: true }).then(() => undefined);
-    }
-
-    await this.indexesPromise;
-  }
 }