lint fix

Author: Dobrunia

src/utils/promoCodeService.ts

@@ -303,24 +303,28 @@ function validateBenefitStructure(benefit: PromoCodeBenefit): void {
       if (!benefit.planId) {
         throw new PromoCodeError(PromoCodeErrorCode.Invalid, 'Grant plan id is missing');
       }
+
       return;
 
     case 'percent_discount':
       if (typeof benefit.percent !== 'number' || benefit.percent <= 0 || benefit.percent > 100) {
         throw new PromoCodeError(PromoCodeErrorCode.Invalid, 'Percent discount is invalid');
       }
+
       return;
 
     case 'amount_discount':
       if (typeof benefit.amount !== 'number' || benefit.amount <= 0) {
         throw new PromoCodeError(PromoCodeErrorCode.Invalid, 'Amount discount is invalid');
       }
+
       return;
 
     case 'fixed_price':
       if (typeof benefit.amount !== 'number' || benefit.amount < DEFAULT_MIN_FINAL_PRICE) {
         throw new PromoCodeError(PromoCodeErrorCode.Invalid, 'Fixed price is invalid');
       }
+
       return;
 
     default:
@@ -333,6 +337,7 @@ function validateBenefitStructure(benefit: PromoCodeBenefit): void {
  *
  * @param pricing - validated promo pricing
  * @param utm - optional UTM data
+ * @returns promo data for payment checksum
  */
 export function buildPaymentPromoData(pricing: PromoCodePricingResult, utm?: Utm): PaymentPromoData {
   return {
@@ -388,26 +393,6 @@ export default class PromoCodeService {
     return promoCode;
   }
 
-  /**
-   * Validates loaded promo code against limits and expiry.
-   *
-   * @param promoCode - promo code model
-   * @param userId - user id
-   * @param workspaceId - workspace id
-   */
-  private async validateLoadedPromoCode(
-    promoCode: PromoCodeModel,
-    userId: string,
-    workspaceId: string
-  ): Promise<void> {
-    if (promoCode.expiresAt && new Date() > new Date(promoCode.expiresAt)) {
-      throw new PromoCodeError(PromoCodeErrorCode.Invalid, 'Promo code expired');
-    }
-
-    validateBenefitStructure(promoCode.benefit);
-    await this.validateUsageLimits(promoCode, userId, new ObjectId(workspaceId));
-  }
-
   /**
    * Validates promo code by id for one selected plan and returns final price.
    *
@@ -437,32 +422,6 @@ export default class PromoCodeService {
     return this.buildPricingResult(promoCode, plan);
   }
 
-  /**
-   * Builds pricing result for validated promo code and plan.
-   *
-   * @param promoCode - promo code model
-   * @param plan - selected plan
-   */
-  private buildPricingResult(promoCode: PromoCodeModel, plan: PlanModel): PromoCodePricingResult {
-    if (promoCode.benefit.type === 'grant_plan') {
-      throw new PromoCodeError(PromoCodeErrorCode.Invalid, 'Grant plan promo cannot be used in payment');
-    }
-
-    const price = calculatePromoCodePlanPrice(promoCode.benefit, plan);
-
-    if (!price.isApplicable) {
-      throw new PromoCodeError(PromoCodeErrorCode.Invalid, 'Promo code is not applicable to selected plan');
-    }
-
-    return {
-      promoCode,
-      benefitType: promoCode.benefit.type,
-      originalAmount: price.originalAmount,
-      finalAmount: price.finalAmount,
-      discountAmount: price.discountAmount,
-    };
-  }
-
   /**
    * Builds preview prices for visible plans.
    *
@@ -599,6 +558,53 @@ export default class PromoCodeService {
     }
   }
 
+  /**
+   * Validates loaded promo code against limits and expiry.
+   *
+   * @param promoCode - promo code model
+   * @param userId - user id
+   * @param workspaceId - workspace id
+   */
+  private async validateLoadedPromoCode(
+    promoCode: PromoCodeModel,
+    userId: string,
+    workspaceId: string
+  ): Promise<void> {
+    if (promoCode.expiresAt && new Date() > new Date(promoCode.expiresAt)) {
+      throw new PromoCodeError(PromoCodeErrorCode.Invalid, 'Promo code expired');
+    }
+
+    validateBenefitStructure(promoCode.benefit);
+    await this.validateUsageLimits(promoCode, userId, new ObjectId(workspaceId));
+  }
+
+  /**
+   * Builds pricing result for validated promo code and plan.
+   *
+   * @param promoCode - promo code model
+   * @param plan - selected plan
+   * @returns validated promo pricing for selected plan
+   */
+  private buildPricingResult(promoCode: PromoCodeModel, plan: PlanModel): PromoCodePricingResult {
+    if (promoCode.benefit.type === 'grant_plan') {
+      throw new PromoCodeError(PromoCodeErrorCode.Invalid, 'Grant plan promo cannot be used in payment');
+    }
+
+    const price = calculatePromoCodePlanPrice(promoCode.benefit, plan);
+
+    if (!price.isApplicable) {
+      throw new PromoCodeError(PromoCodeErrorCode.Invalid, 'Promo code is not applicable to selected plan');
+    }
+
+    return {
+      promoCode,
+      benefitType: promoCode.benefit.type,
+      originalAmount: price.originalAmount,
+      finalAmount: price.finalAmount,
+      discountAmount: price.discountAmount,
+    };
+  }
+
   /**
    * Validates all usage limits.
    *

src/utils/utm/utm.ts

@@ -9,6 +9,7 @@ const VALID_UTM_KEYS = ['source', 'medium', 'campaign', 'content', 'term'] as co
  * Checks that passed key is supported UTM field.
  *
  * @param key - UTM object key
+ * @returns whether key is a valid UTM field
  */
 function isValidUtmKey(key: string): key is keyof Utm {
   return (VALID_UTM_KEYS as readonly string[]).includes(key);
@@ -30,7 +31,7 @@ const MAX_UTM_VALUE_LENGTH = 50;
  * @param {Object} utm - UTM parameters to validate
  * @returns {Object} - filtered valid UTM parameters
  */
-export function validateUtmParams(utm: any): Utm | undefined {
+export function validateUtmParams(utm: unknown): Utm | undefined {
   if (!utm || typeof utm !== 'object' || Array.isArray(utm)) {
     return undefined;
   }