Fix RSS/Atom feed: include status in description, strip format param from links (#658)

Feed item descriptions were missing the actual health status, and item
links carried the `?format=rss` query parameter — making them
machine-readable URLs rather than human-readable ones.

---------

Co-authored-by: codingjoe <1772890+codingjoe@users.noreply.github.com>

Author: Copilot

health_check/views.py

@@ -249,7 +249,7 @@ def _render_feed(self, feed_class):
         """Generate RSS or Atom feed with health check results."""
         feed = feed_class(
             title="Health Check Status",
-            link=self.request.build_absolute_uri(),
+            link=self.request.build_absolute_uri(self.request.path),
             description="Current status of system health checks",
             feed_url=self.request.build_absolute_uri(),
         )
@@ -262,8 +262,8 @@ def _render_feed(self, feed_class):
             )
             feed.add_item(
                 title=repr(result.check),
-                link=self.request.build_absolute_uri(),
-                description=f"{result.check!r}\nResponse time: {result.time_taken:.3f}s",
+                link=self.request.build_absolute_uri(self.request.path),
+                description=str(result.error) if result.error else "OK",
                 pubdate=published_at,
                 updateddate=published_at,
                 author_name=self.feed_author,

tests/test_views.py

@@ -566,6 +566,91 @@ async def run(self):
             "Failed check should use current timestamp in mixed feed"
         )
 
+    @pytest.mark.asyncio
+    async def test_get__rss_feed_description_includes_status(self, health_check_view):
+        """RSS feed item description includes status message."""
+        feedparser = pytest.importorskip("feedparser")
+
+        class FailingBackend(HealthCheck):
+            async def run(self):
+                raise HealthCheckException("Something went wrong")
+
+        response = await health_check_view([FailingBackend], format_param="rss")
+        feed = feedparser.parse(response.content.decode("utf-8"))
+        assert len(feed.entries) == 1
+        entry = feed.entries[0]
+        assert "Something went wrong" in entry.summary, (
+            "Feed description should include the actual error message"
+        )
+
+    @pytest.mark.asyncio
+    async def test_get__rss_feed_description_healthy_shows_ok(self, health_check_view):
+        """RSS feed item description shows OK for healthy checks."""
+        feedparser = pytest.importorskip("feedparser")
+
+        class SuccessBackend(HealthCheck):
+            async def run(self):
+                pass
+
+        response = await health_check_view([SuccessBackend], format_param="rss")
+        feed = feedparser.parse(response.content.decode("utf-8"))
+        assert len(feed.entries) == 1
+        entry = feed.entries[0]
+        assert "OK" in entry.summary, (
+            "Feed description should show OK for healthy checks"
+        )
+
+    @pytest.mark.asyncio
+    async def test_get__rss_feed_link_excludes_format_param(self, health_check_view):
+        """RSS feed item link does not include the format query parameter."""
+        feedparser = pytest.importorskip("feedparser")
+
+        class SuccessBackend(HealthCheck):
+            async def run(self):
+                pass
+
+        response = await health_check_view([SuccessBackend], format_param="rss")
+        feed = feedparser.parse(response.content.decode("utf-8"))
+        assert len(feed.entries) == 1
+        entry = feed.entries[0]
+        assert "format=rss" not in entry.link, (
+            "Feed item link should not include the format query parameter"
+        )
+
+    @pytest.mark.asyncio
+    async def test_get__atom_feed_description_includes_status(self, health_check_view):
+        """Atom feed item description includes status message."""
+        feedparser = pytest.importorskip("feedparser")
+
+        class FailingBackend(HealthCheck):
+            async def run(self):
+                raise HealthCheckException("Database unreachable")
+
+        response = await health_check_view([FailingBackend], format_param="atom")
+        feed = feedparser.parse(response.content.decode("utf-8"))
+        assert len(feed.entries) == 1
+        entry = feed.entries[0]
+        assert "Database unreachable" in entry.summary, (
+            "Feed description should include the actual error message"
+        )
+
+    @pytest.mark.asyncio
+    async def test_get__atom_feed_link_excludes_format_param(self, health_check_view):
+        """Atom feed item link does not include the format query parameter."""
+        feedparser = pytest.importorskip("feedparser")
+
+        class SuccessBackend(HealthCheck):
+            async def run(self):
+                pass
+
+        response = await health_check_view([SuccessBackend], format_param="atom")
+        feed = feedparser.parse(response.content.decode("utf-8"))
+        assert len(feed.entries) == 1
+        entry = feed.entries[0]
+        assert "format=atom" not in entry.link, (
+            "Feed item link should not include the format query parameter"
+        )
+
     @pytest.mark.asyncio
     async def test_get_plugins__with_string_import(self):
         """Import check from string path."""