Make Redis connection arguments in repr optional (#664)

Ref #659

Author: codingjoe

health_check/contrib/redis.py

@@ -62,11 +62,15 @@ def __repr__(self):
             client = self.client
 
         try:
-            conn_kwargs = client.connection_pool.connection_kwargs
-            host = conn_kwargs["host"]
-            db = conn_kwargs["db"]
-            return f"Redis(client=RedisClient(host={host}, db={db}))"
-        except (AttributeError, KeyError):
+            safe_connection_str = ", ".join(
+                f"{key}={value!r}"
+                for key, value in sorted(
+                    client.connection_pool.connection_kwargs.items()
+                )
+                if key in {"host", "db"}
+            )
+            return f"Redis({safe_connection_str})"
+        except AttributeError:
             pass
 
         try:

tests/contrib/test_redis.py

@@ -156,7 +156,7 @@ def test_redis__repr_standard_client(self):
         check = RedisHealthCheck(
             client_factory=lambda: RedisClient(host="myhost", port=6379, db=2)
         )
-        assert repr(check) == "Redis(client=RedisClient(host=myhost, db=2))"
+        assert repr(check) == "Redis(db=2, host='myhost')"
 
     def test_redis__repr_from_url(self):
         """Verify repr includes host and db when client is created via from_url."""
@@ -167,7 +167,7 @@ def test_redis__repr_from_url(self):
                 "redis://cache.example.com:6379/3"
             )
         )
-        assert "host=cache.example.com" in repr(check), (
+        assert "host='cache.example.com'" in repr(check), (
             "repr should include the host from the Redis URL"
         )
         assert "db=3" in repr(check), "repr should include the db from the Redis URL"
@@ -180,7 +180,7 @@ def test_redis__repr_deprecated_client(self):
             check = RedisHealthCheck(
                 client=RedisClient(host="oldhost", port=6379, db=5)
             )
-        assert "host=oldhost" in repr(check), (
+        assert "host='oldhost'" in repr(check), (
             "repr should include the host from the deprecated client"
         )
         assert "db=5" in repr(check), (