Skip to content

captcha: fix non-mutating compare#12

Open
nicholascalvert85 wants to merge 1 commit into
codingstella:mainfrom
nicholascalvert85:feat/captcha-hardening
Open

captcha: fix non-mutating compare#12
nicholascalvert85 wants to merge 1 commit into
codingstella:mainfrom
nicholascalvert85:feat/captcha-hardening

Conversation

@nicholascalvert85
Copy link
Copy Markdown

avoid mutating stored captcha during validation by comparing normalized strings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 8, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Custom Captcha Generator using JS/dist/script.js is excluded by !**/dist/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@vponkratina vponkratina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR resolves a critical bug by ensuring that the stored captcha value isn't mutated during validation, following a more functional approach by creating normalized copies for comparison. However, I couldn't review this PR in more detail because I couldn't retrieve specific coding conventions for this programming language. If you'd like me to proceed otherwise or check for something specific, let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants