fix: replace custom version comparison with ALPM Library

- requires libalpm from pacman package

Author: coffebar

Cargo.lock

@@ -16,6 +16,7 @@ path = "src/main.rs"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
+alpm = "4.0"
 lazy_static = "1.4"
 lenient_semver = "0.4.2"
 ureq = { version = "2.10", features = ["json"] }

Cargo.toml

@@ -1,38 +1,15 @@
 pub mod version_utils {
+    use alpm::vercmp;
     use lenient_semver;
+    use std::cmp::Ordering;
 
-    // Helper function to compare versions properly
+    // Helper function to compare versions using ALPM's vercmp for production consistency
     pub fn is_version_newer(aur_version: &str, local_version: &str) -> bool {
-        // Handle git packages with revision numbers (e.g., "r89.fe26a90-1" or "-r89.fe26a90-1")
-        let extract_git_revision = |version: &str| -> Option<u32> {
-            if let Some(r_pos) = version.find('r') {
-                let after_r = &version[r_pos + 1..];
-                if let Some(dot_pos) = after_r.find('.') {
-                    if let Ok(rev) = after_r[..dot_pos].parse() {
-                        return Some(rev);
-                    }
-                }
-            }
-            None
-        };
-
-        // If both versions have git revision numbers, compare them
-        if let (Some(aur_rev), Some(local_rev)) = (
-            extract_git_revision(aur_version),
-            extract_git_revision(local_version),
-        ) {
-            return aur_rev > local_rev;
-        }
-
-        // Fall back to semantic version comparison
-        match (
-            lenient_semver::parse(aur_version),
-            lenient_semver::parse(local_version),
-        ) {
-            (Ok(aur_semver), Ok(local_semver)) => aur_semver > local_semver,
-            // If semantic parsing fails, fall back to string comparison
-            // but only show as update if strings are different (conservative approach)
-            _ => aur_version != local_version && aur_version > local_version,
+        // Use ALPM's vercmp which follows Arch Linux's official version comparison algorithm
+        // vercmp returns Ordering::Greater if aur_version is newer than local_version
+        match vercmp(aur_version, local_version) {
+            Ordering::Greater => true,
+            _ => false,
         }
     }
 

src/lib.rs

@@ -14,13 +14,17 @@ fn test_version_comparison_git_revisions() {
     assert!(is_version_newer("r100.abc123-1", "r99.def456-1"));
     assert!(!is_version_newer("r99.abc123-1", "r100.def456-1"));
     assert!(!is_version_newer("r100.abc123-1", "r100.def456-1"));
+    assert!(is_version_newer(
+        "0.48.0.r62.gd775686-1",
+        "0.47.0.r63.ccdddddd-2"
+    ));
 }
 
 #[test]
 fn test_version_comparison_mixed() {
     assert!(is_version_newer("1.2.1-r50.abc123", "1.2.0"));
-    assert!(!is_version_newer("2.0.0", "r100.abc123-1")); // semantic vs git revision - should be false
-    assert!(is_version_newer("r101.abc123-1", "1.2.0")); // git revision vs semantic - string comparison
+    assert!(is_version_newer("2.0.0", "r100.abc123-1")); // ALPM: semantic version is newer than git revision
+    assert!(!is_version_newer("r101.abc123-1", "1.2.0")); // ALPM: git revision is older than semantic version
 }
 
 #[test]