-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Currently, there are a few issues with the feature API:
- Instance methods: the methods such as
is_cat()should be class attributes, not instance methods, as they do not require processing and do not vary between instances - Validation: currently, validation is performed in the
ProblemConfig.add_featuremethod. The responsibility to validate should belong to the feature - Naming: each class should have
Featureat the end to make it clear that this is a custom object for representing features.
Each of these changes would break the existing API, so I am deferring these changes until the next major release. A good solution would use attrs to create dataclasses.
We should also consider whether using an existing API like bofire would be feasible.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request