Skip to content

Commit 3edb7d4

Browse files
authored
Merge pull request #45 from cognitect/cache-fix
2 parents dc0d22e + d85f75d commit 3edb7d4

3 files changed

Lines changed: 2 additions & 44 deletions

File tree

src/main/java/com/cognitect/transit/impl/Cache.java

Lines changed: 0 additions & 19 deletions
This file was deleted.

src/main/java/com/cognitect/transit/impl/ReaderFactory.java

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515

1616
public class ReaderFactory {
1717

18-
private static Map<Map<String, ReadHandler<?,?>>, ReadHandlerMap> handlerCache = new Cache<Map<String, ReadHandler<?,?>>, ReadHandlerMap>();
19-
2018
public static Map<String, ReadHandler<?,?>> defaultHandlers() {
2119

2220
Map<String, ReadHandler<?,?>> handlers = new HashMap<String, ReadHandler<?,?>>();
@@ -58,15 +56,7 @@ private static Map<String, ReadHandler<?,?>> handlerMap(Map<String, ReadHandler<
5856
if (customHandlers instanceof ReadHandlerMap) {
5957
return customHandlers;
6058
}
61-
62-
synchronized (ReaderFactory.class) {
63-
ReadHandlerMap readHandlerMap = handlerCache.get(customHandlers);
64-
if (readHandlerMap == null) {
65-
readHandlerMap = new ReadHandlerMap(customHandlers);
66-
handlerCache.put(customHandlers, readHandlerMap);
67-
}
68-
return readHandlerMap;
69-
}
59+
return new ReadHandlerMap(customHandlers);
7060
}
7161

7262
private static DefaultReadHandler defaultHandler(DefaultReadHandler customDefaultHandler) {

src/main/java/com/cognitect/transit/impl/WriterFactory.java

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,8 @@
1717

1818
public class WriterFactory {
1919

20-
private static final Map<Map<Class, WriteHandler<?,?>>, WriteHandlerMap> handlerCache = new Cache<Map<Class, WriteHandler<?,?>>, WriteHandlerMap>();
21-
2220
private static WriteHandlerMap buildWriteHandlerMap(Map<Class, WriteHandler<?, ?>> customHandlers) {
23-
if (customHandlers instanceof WriteHandlerMap)
24-
return new WriteHandlerMap(customHandlers);
25-
26-
WriteHandlerMap writeHandlerMap;
27-
synchronized (handlerCache) {
28-
writeHandlerMap = handlerCache.get(customHandlers);
29-
if (writeHandlerMap == null) {
30-
writeHandlerMap = new WriteHandlerMap(customHandlers);
31-
handlerCache.put(customHandlers, writeHandlerMap);
32-
}
33-
}
34-
return new WriteHandlerMap(writeHandlerMap);
21+
return new WriteHandlerMap(customHandlers);
3522
}
3623

3724
private static WriteHandlerMap verboseHandlerMap(Map<Class, WriteHandler<?, ?>> customHandlers) {

0 commit comments

Comments
 (0)