Merge pull request #49 from cognitect/issue-47

puredanger · web-flow · commit 9f72162487fd · 2026-02-27T11:19:11.000-07:00
[Bug] Remove impossible bounds checking.
diff --git a/src/main/java/com/cognitect/transit/impl/MsgpackEmitter.java b/src/main/java/com/cognitect/transit/impl/MsgpackEmitter.java
@@ -60,16 +60,12 @@ public void emitBoolean(boolean b, boolean asMapKey, WriteCache cache) throws Ex
     @Override
     public void emitInteger(Object o, boolean asMapKey, WriteCache cache) throws Exception {
         long i = Util.numberToPrimitiveLong(o);
-        if ((i > Long.MAX_VALUE) || (i < Long.MIN_VALUE))
-            this.emitString(Constants.ESC_STR, "i", o.toString(), asMapKey, cache);
         this.gen.packLong(i);
     }
 
 
     @Override
     public void emitInteger(long i, boolean asMapKey, WriteCache cache) throws Exception {
-        if ((i > Long.MAX_VALUE) || (i < Long.MIN_VALUE))
-            this.emitString(Constants.ESC_STR, "i", String.valueOf(i), asMapKey, cache);
         this.gen.packLong(i);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -60,16 +60,12 @@ public void emitBoolean(boolean b, boolean asMapKey, WriteCache cache) throws Ex`
`60`	`60`	`@Override`
`61`	`61`	`public void emitInteger(Object o, boolean asMapKey, WriteCache cache) throws Exception {`
`62`	`62`	`long i = Util.numberToPrimitiveLong(o);`
`63`		`- if ((i > Long.MAX_VALUE) \|\| (i < Long.MIN_VALUE))`
`64`		`- this.emitString(Constants.ESC_STR, "i", o.toString(), asMapKey, cache);`
`65`	`63`	`this.gen.packLong(i);`
`66`	`64`	`}`
`67`	`65`
`68`	`66`
`69`	`67`	`@Override`
`70`	`68`	`public void emitInteger(long i, boolean asMapKey, WriteCache cache) throws Exception {`
`71`		`- if ((i > Long.MAX_VALUE) \|\| (i < Long.MIN_VALUE))`
`72`		`- this.emitString(Constants.ESC_STR, "i", String.valueOf(i), asMapKey, cache);`
`73`	`69`	`this.gen.packLong(i);`
`74`	`70`	`}`
`75`	`71`