[FIX] fix various mem leaks

Author: TimSiebert1

.github/workflows/tests.yml

@@ -59,9 +59,10 @@ jobs:
 
     - name: Run with Valgrind
       run: |
+        # we use definite,indirect (and not possible) to not error on common omp errors
         valgrind --leak-check=full \
-                 --show-leak-kinds=all \
-                 --errors-for-leak-kinds=all \
+                 --show-leak-kinds=definite,indirect \
+                 --errors-for-leak-kinds=definite,indirect \
                  --error-exitcode=1 \
                  ${{ steps.strings.outputs.build-output-dir }}/ADOL-C/boost-test/boost-test-adolc
 

ADOL-C/boost-test/sparse/sparse_abs_normal.cpp

@@ -445,6 +445,8 @@ template <size_t Version> static void problem() {
       BOOST_TEST(crs[row][col] == anfProblemAlloc.crs[row][col]);
     }
   };
+  for (auto& c: crs)
+    delete[] c;
 }
 
 BOOST_AUTO_TEST_CASE(SparseANFPatTest) {

ADOL-C/boost-test/sparse/sparse_hessian.cpp

@@ -20,7 +20,7 @@ using ADOLC::Sparse::RecoveryMethod;
  identifies and recovers only the diagonal nonzero entries.
 
  The function is:
-   f(x) = Σ_{i=0}^{4} [ sin(x_i) + (x_{i+10})^2 ]
+   f(x) = sum_{i=0}^{4} [ sin(x_i) + (x_{i+10})^2 ]
 
  Analytical Hessian (expected):
    For i = 0,... , 4:
@@ -106,7 +106,6 @@ static void testSparseHessWithDiagonal(short tapeId) {
     // we only have diagonal elements
     BOOST_TEST(rowIndices[i] == columnIndices[i]);
   }
-
   // test with rowIndices, columnIndices and sparseValues != nullptr
   ADOLC::Sparse::sparse_hess<CFM, RCM>(tapeId, dimIn, 0, in.data(),
                                        &numberOfNonzeros, &rowIndices,
@@ -127,7 +126,6 @@ static void testSparseHessWithDiagonal(short tapeId) {
     // we only have diagonal elements
     BOOST_TEST(rowIndices[i] == columnIndices[i]);
   }
-
   // test with repeat == 1
   ADOLC::Sparse::sparse_hess<CFM, RCM>(tapeId, dimIn, 1, in.data(),
                                        &numberOfNonzeros, &rowIndices,
@@ -148,7 +146,9 @@ static void testSparseHessWithDiagonal(short tapeId) {
     // we only have diagonal elements
     BOOST_TEST(rowIndices[i] == columnIndices[i]);
   }
-  delete sparseValues;
+  delete[] sparseValues;
+  delete[] columnIndices;
+  delete[] rowIndices;
   for (auto &h : hess)
     delete[] h;
 }
@@ -164,7 +164,6 @@ BOOST_AUTO_TEST_CASE(SparseHessSafeIndirect) {
   testSparseHessWithDiagonal<ControlFlowMode::Safe, RecoveryMethod::Indirect>(
       tapeId);
 }
-
 BOOST_AUTO_TEST_CASE(SparseHessTightDirect) {
   const short tapeId = 634;
   testSparseHessWithDiagonal<ControlFlowMode::Tight, RecoveryMethod::Direct>(
@@ -200,7 +199,6 @@ BOOST_AUTO_TEST_CASE(SparseHessOldTightIndirect) {
   testSparseHessWithDiagonal<ControlFlowMode::OldTight,
                              RecoveryMethod::Indirect>(tapeId);
 }
-
 /*
  This test constructs a function with mixed-product terms so that the Hessian
  contains off-diagonal nonzeros.
@@ -314,15 +312,15 @@ static void testSparseHessWithOffDiagonals(short tapeId) {
   delete[] rowIndices;
   delete[] columnIndices;
   delete[] sparseValues;
-  for (auto &ptr : hess)
-    delete[] ptr;
+  for (auto &h: hess)
+    delete[] h;
 }
-
 BOOST_AUTO_TEST_CASE(SparseHessNonDiagSafeDirect) {
   const short tapeId = 700;
   testSparseHessWithOffDiagonals<ControlFlowMode::Safe, RecoveryMethod::Direct>(
       tapeId);
 }
+
 BOOST_AUTO_TEST_CASE(SparseHessNonDiagSafeIndirect) {
   const short tapeId = 701;
   testSparseHessWithOffDiagonals<ControlFlowMode::Safe,
@@ -435,6 +433,9 @@ static void testSparseHessPatWithDiagonal(short tapeId) {
   BOOST_TEST(compressedRowStorage[17][0] == 0);
   BOOST_TEST(compressedRowStorage[18][0] == 0);
   BOOST_TEST(compressedRowStorage[19][0] == 0);
+
+  for (auto& crs: compressedRowStorage)
+    delete[] crs;
 }
 
 BOOST_AUTO_TEST_CASE(SparseHessPatDiagSafe) {
@@ -519,6 +520,9 @@ static void testSparseHessPatWithOffDiagonal(short tapeId) {
   // sixth hessian row has fifth
   BOOST_TEST(compressedRowStorage[5][0] == 1);
   BOOST_TEST(compressedRowStorage[5][1] == 4);
+
+  for (auto& crs: compressedRowStorage)
+    delete[] crs;
 }
 
 BOOST_AUTO_TEST_CASE(SparseHessPatOffDiagSafe) {
@@ -540,5 +544,4 @@ BOOST_AUTO_TEST_CASE(SparseHessPatOffDiagOldTight) {
   const short tapeId = 715;
   testSparseHessPatWithOffDiagonal<ControlFlowMode::OldTight>(tapeId);
 }
-
-BOOST_AUTO_TEST_SUITE_END()
+BOOST_AUTO_TEST_SUITE_END()

ADOL-C/boost-test/sparse/sparse_jacobian.cpp

@@ -1,4 +1,3 @@
-
 #include <algorithm>
 #include <boost/test/tools/old/interface.hpp>
 #define BOOST_TEST_DYN_LINK
@@ -94,6 +93,9 @@ static void testSparseJac(short tapeId) {
       }
     }
   }
+  delete[] rowIndices;
+  delete[] columnIndices;
+  delete[] nonzeroValues;
   for (auto &j : jac)
     delete[] j;
 }
@@ -205,6 +207,9 @@ static void testSparseJacPat(short tapeId) {
   BOOST_TEST(compressedRowStorage[1][1] == 2);
   BOOST_TEST(compressedRowStorage[1][2] == 5);
   BOOST_TEST(compressedRowStorage[1][3] == 6);
+
+  for (auto& crs: compressedRowStorage)
+    delete[] crs;
 }
 
 BOOST_AUTO_TEST_CASE(SparseJacPatIndexSafe) {
@@ -226,5 +231,4 @@ BOOST_AUTO_TEST_CASE(SparseJacPatBitPatternTight) {
   short tapeId = 578;
   testSparseJacPat<SparseMethod::BitPattern, ControlFlowMode::Tight>(tapeId);
 }
-
 BOOST_AUTO_TEST_SUITE_END()

ADOL-C/include/adolc/sparse/sparsedrivers.h

@@ -772,6 +772,8 @@ int computeSparseJac(short tag, int depen, int indep, const double *basepoint,
                      double **values) {
   ValueTape &tape = findTape(tag);
   int ret_val = 0;
+  myfree2(tape.sJInfos().B_);
+  myfree1(tape.sJInfos().y_);
   tape.sJInfos().B_ =
       myalloc2(tape.sJInfos().seedRows_, tape.sJInfos().seedClms_);
   tape.sJInfos().y_ = myalloc1(depen);
@@ -799,9 +801,9 @@ int computeSparseJac(short tag, int depen, int indep, const double *basepoint,
     // everything is preallocated, we assume correctly
     // call usermem versions
     if (CM == CompressionMode::Row)
-      tape.sJInfos().recoverRowFormat(rind, cind, values);
+      tape.sJInfos().recoverRowFormatUserMem(rind, cind, values);
     else if (CM == CompressionMode::Column)
-      tape.sJInfos().recoverColFormat(rind, cind, values);
+      tape.sJInfos().recoverColFormatUserMem(rind, cind, values);
   } else {
     // at least one of rind cind values is not allocated, deallocate others
     // and call unmanaged versions
@@ -1061,23 +1063,28 @@ int buildHessPatternAndSeed(short tag, int indep, const double *basepoint,
 
   // compute seed matrix => ColPack library
 
+  // Seed is handled by ColPack
   double **Seed = nullptr;
   tape.sHInfos().initColoring(indep);
   if constexpr (RCM == RecoveryMethod::Indirect)
     tape.sHInfos().generateSeedHess(&Seed, "ACYCLIC_FOR_INDIRECT_RECOVERY");
   else if (RCM == RecoveryMethod::Direct)
     tape.sHInfos().generateSeedHess(&Seed, "STAR");
 
+  // data might still be allocated, ensure that its not leaked
+  myfree2(tape.sHInfos().Hcomp_);
+  myfree3(tape.sHInfos().Xppp_);
+  myfree3(tape.sHInfos().Yppp_);
+  myfree3(tape.sHInfos().Zppp_);
+  myfree2(tape.sHInfos().Upp_);
+
   tape.sHInfos().Hcomp_ = myalloc2(indep, tape.sHInfos().p_);
   tape.sHInfos().Xppp_ = myalloc3(indep, tape.sHInfos().p_, 1);
 
   for (int i = 0; i < indep; i++)
     for (int l = 0; l < tape.sHInfos().p_; l++)
       tape.sHInfos().Xppp_[i][l][0] = Seed[i][l];
 
-  // Seed will be freed by ColPack when g is freed
-  Seed = nullptr;
-
   tape.sHInfos().Yppp_ = myalloc3(1, tape.sHInfos().p_, 1);
   tape.sHInfos().Zppp_ = myalloc3(tape.sHInfos().p_, indep, 2);
   tape.sHInfos().Upp_ = myalloc2(1, 2);
@@ -1162,12 +1169,18 @@ int computeSparseHess(short tag, int indep, const double *basepoint, int *nnz,
   } else {
     // at least one of rind cind values is not allocated, deallocate others
     // and call unmanaged versions
-    if (*values != nullptr)
-      free(*values);
-    if (*rind != nullptr)
-      free(*rind);
-    if (*cind != nullptr)
-      free(*cind);
+    if (*values != nullptr){
+      delete[] *values;
+      *values = nullptr;
+    }
+    if (*rind != nullptr){
+      delete[] *rind;
+      *rind = nullptr;
+    }
+    if (*cind != nullptr){
+      delete[] *cind;
+      *cind = nullptr;
+    }
     if constexpr (RCM == RecoveryMethod::Indirect)
       tape.sHInfos().indirectRecover(rind, cind, values);
     else if (RCM == RecoveryMethod::Direct)

ADOL-C/include/adolc/valuetape/sparseinfos.h

@@ -37,6 +37,9 @@ struct ADOLC_API SparseJacInfos {
   SparseJacInfos &operator=(SparseJacInfos &&other) noexcept;
 
   void setJP(std::vector<uint *> &&JPIn) {
+    // delete JP
+    for (auto& j: JP_)
+      delete[] j;
     JP_ = std::move(JPIn);
     depen_ = JP_.size();
   }
@@ -84,6 +87,9 @@ struct ADOLC_API SparseHessInfos {
 
   std::vector<uint *> &getHP() { return HP_; }
   void setHP(int indep, std::vector<uint *> &&HPIn) {
+    // delete HP_
+    for (auto& h: HP_)
+      delete[] h;
     indep_ = indep;
     HP_ = std::move(HPIn);
   }
@@ -98,4 +104,4 @@ struct ADOLC_API SparseHessInfos {
                        double **values);
 };
 } // namespace ADOLC::Sparse
-#endif // ADOLC_SPARSE_INFOS_H
+#endif // ADOLC_SPARSE_INFOS_H

ADOL-C/include/adolc/valuetape/valuetape.h

@@ -760,4 +760,4 @@ class ADOLC_API ValueTape {
   CpInfos *get_cp_fct(int index) { return cp_buffer_.getElement(index); }
 };
 
-#endif // ADOLC_VALUETAPE_H
+#endif // ADOLC_VALUETAPE_H

ADOL-C/src/uni5_for.cpp

@@ -5941,7 +5941,7 @@ int hov_forward(
 #if defined(_INDO_)
 #if defined(_INDOPRO_)
   for (int i = 0; i < max_ind_dom; i++) {
-    delete ind_dom[i];
+    delete[] ind_dom[i];
   }
   delete[] ind_dom;
 #endif
@@ -5955,15 +5955,15 @@ int hov_forward(
     for (int ii = 1; ii <= sod[i].entry; ii++) {
       crs[i][ii] = temp->entry;
       temp1 = temp->left;
-      free(temp);
+      delete temp;
       temp = temp1;
     }
   }
 
-  delete sod;
-  delete nonl_dom;
-  delete fod;
-  delete arg_index;
+  delete[] sod;
+  delete[] nonl_dom;
+  delete[] fod;
+  delete[] arg_index;
 
 #endif
 #if defined(_NONLIND_OLD_)
@@ -5973,7 +5973,7 @@ int hov_forward(
     crs[i][0] = nonl_dom[i][0];
     for (l = 1; l < crs[i][0] + 1; l++)
       crs[i][l] = nonl_dom[i][l + 1];
-    delete nonl_dom[i];
+    delete[] nonl_dom[i];
   }
   delete[] nonl_dom;
 
@@ -6111,7 +6111,7 @@ void merge_2_index_domains(int res, int arg, locint **ind_dom) {
         k++;
       }
       temp_array[0] = k - 2;
-      delete ind_dom[res];
+      delete[] ind_dom[res];
       ind_dom[res] = temp_array;
     }
   }
@@ -6146,7 +6146,7 @@ void free_tree(IndexElement *tree, int num) {
   }
   {
     if (tree->entry == num)
-      free(tree);
+      delete tree;
   }
 }
 void traverse_crs(IndexElement *tree, IndexElement_sod *sod, int num) {
@@ -6291,7 +6291,7 @@ void extend_nonlinearity_domain_binary_step(int arg1, int arg2,
         k++;
       }
       temp_nonl[0] = k - 2;
-      delete nonl_dom[index];
+      delete[] nonl_dom[index];
       nonl_dom[index] = temp_nonl;
     }
   }